freebsd-dev/usr.bin/hexdump/Makefile

#	@(#)Makefile	8.1 (Berkeley) 6/6/93
# $FreeBSD$

PROG=	hexdump
SRCS=	conv.c display.c hexdump.c hexsyntax.c odsyntax.c parse.c
MAN=	hexdump.1 od.1
MLINKS=	hexdump.1 hd.1
LINKS=	${BINDIR}/hexdump ${BINDIR}/od
LINKS+=	${BINDIR}/hexdump ${BINDIR}/hd
WARNS?=	6

.include <bsd.prog.mk>
BSD 4.4 Lite Usr.bin Sources 1994-05-27 12:33:43 +00:00			`# @(#)Makefile 8.1 (Berkeley) 6/6/93`
MAN[1-9] -> MAN. 2001-03-27 10:52:19 +00:00			`# $FreeBSD$`
BSD 4.4 Lite Usr.bin Sources 1994-05-27 12:33:43 +00:00
			`PROG= hexdump`
			`SRCS= conv.c display.c hexdump.c hexsyntax.c odsyntax.c parse.c`
MAN[1-9] -> MAN. 2001-03-27 10:52:19 +00:00			`MAN= hexdump.1 od.1`
Now that we've already got "hexdump -C", make calling the command "hd" having the same effect, and install a link for this. There is historic precedence for the command hd(1) (with roughly that output format) in Xenix, SCO, and a few SysV's that tooks the idea. Also, added a couple of spaces to the -C format to make the output better readable. Ok'ed by: phk 1996-09-29 04:17:24 +00:00			`MLINKS= hexdump.1 hd.1`
BSD 4.4 Lite Usr.bin Sources 1994-05-27 12:33:43 +00:00			`LINKS= ${BINDIR}/hexdump ${BINDIR}/od`
Now that we've already got "hexdump -C", make calling the command "hd" having the same effect, and install a link for this. There is historic precedence for the command hd(1) (with roughly that output format) in Xenix, SCO, and a few SysV's that tooks the idea. Also, added a couple of spaces to the -C format to make the output better readable. Ok'ed by: phk 1996-09-29 04:17:24 +00:00			`LINKS+= ${BINDIR}/hexdump ${BINDIR}/hd`
display.c: - 'savech' is only used if it is set a few lines above where it is used, initialize it to silence warning. - 'length' is either -1 or greater than 0, hence it is safe to cast it to unsigned when comparing it here. odsyntax.c: - 'p' is assigned either (argvp)[0] or (argvp)[1] which both are char . 'num' and 'end' are assigned values based on 'p'. Hence use char instead of unsigned char * for these variables. '&end' as the second argument to strtoll does not need to be casted to char** any more. This solves a 'dereferencing type-punned pointer will break strict-aliasing rules' warning when compiling with -O2. parse.c: - 'prec' is only used when sokay == USEPREC and sokay = USEPREC when 'prec' is assigned. Hence 'prec' is not used uninitialized, initialize it to silence warning. - The code involving 'nextpr' is hard to follow, but I belive 'nextpr' will not be used unless it is initialized. Anyway, IF 'nextpr' is used uninitialized it is better to get a consistant error (seg fault, when dereferencing a NULL pointer) than potentially accessing some random memory. The above changes makes hexdump WARNS=6 clean even when compiled with -O2. Hence bump WARNS to keep it clean. Tested by: CFLAGS='-O2 -pipe' make universe 2004-07-22 13:14:42 +00:00			`WARNS?= 6`
BSD 4.4 Lite Usr.bin Sources 1994-05-27 12:33:43 +00:00
			`.include <bsd.prog.mk>`