d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
f8c60df7a6
freebsd-dev/sys/netnatm/natm.c

767 lines
18 KiB
C
Raw Normal View History

import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
/* $NetBSD: natm.c,v 1.5 1996/11/09 03:26:26 chuck Exp $ */
/*
*
* Copyright (c) 1996 Charles D. Cranor and Washington University.
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
* 3. All advertising materials mentioning features or use of this software
* must display the following acknowledgement:
* This product includes software developed by Charles D. Cranor and
* Washington University.
* 4. The name of the author may not be used to endorse or promote products
* derived from this software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
* IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
* IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
* NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
/*
* natm.c: native mode ATM access (both aal0 and aal5).
*/
Use __FBSDID().
2003-06-11 05:37:42 +00:00
#include <sys/cdefs.h>
__FBSDID("$FreeBSD$");
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
#include <sys/param.h>
Revert the change of #includes in sys/filedesc.h and sys/socketvar.h. Requested by: bde Since locking sigio_lock is usually followed by calling pgsigio(), move the declaration of sigio_lock and the definitions of SIGIO_*() to sys/signalvar.h. While I am here, sort include files alphabetically, where possible.
2002-04-30 01:54:54 +00:00
#include <sys/conf.h>
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
#include <sys/kernel.h>
Revert the change of #includes in sys/filedesc.h and sys/socketvar.h. Requested by: bde Since locking sigio_lock is usually followed by calling pgsigio(), move the declaration of sigio_lock and the definitions of SIGIO_*() to sys/signalvar.h. While I am here, sort include files alphabetically, where possible.
2002-04-30 01:54:54 +00:00
#include <sys/lock.h>
Added used #include - don't depend on <sys/mbuf.h> including <sys/malloc.h> (unless we only use the bogusly shared M*WAIT flags).
1997-09-02 01:19:47 +00:00
#include <sys/malloc.h>
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
#include <sys/mbuf.h>
Revert the change of #includes in sys/filedesc.h and sys/socketvar.h. Requested by: bde Since locking sigio_lock is usually followed by calling pgsigio(), move the declaration of sigio_lock and the definitions of SIGIO_*() to sys/signalvar.h. While I am here, sort include files alphabetically, where possible.
2002-04-30 01:54:54 +00:00
#include <sys/protosw.h>
#include <sys/signalvar.h>
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
#include <sys/socket.h>
#include <sys/socketvar.h>
Revert the change of #includes in sys/filedesc.h and sys/socketvar.h. Requested by: bde Since locking sigio_lock is usually followed by calling pgsigio(), move the declaration of sigio_lock and the definitions of SIGIO_*() to sys/signalvar.h. While I am here, sort include files alphabetically, where possible.
2002-04-30 01:54:54 +00:00
#include <sys/sockio.h>
#include <sys/sx.h>
#include <sys/systm.h>
Style(9): remove unneccesary space and blank lines, indentation, function prototypes. Use LIST_FOREACH instead of explicit loops. The indentation of functions indendet by 4 space have been left alone. 2-space indented functions have been re-indented.
2003-08-06 13:46:15 +00:00
#include <sys/sysctl.h>
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
#include <net/if.h>
#include <net/if_atm.h>
#include <net/netisr.h>
#include <netinet/in.h>
#include <netnatm/natm.h>
Constify send and receive space constants in natm.
2004-06-24 03:11:29 +00:00
static const u_long natm5_sendspace = 16*1024;
static const u_long natm5_recvspace = 16*1024;
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
Constify send and receive space constants in natm.
2004-06-24 03:11:29 +00:00
static const u_long natm0_sendspace = 16*1024;
static const u_long natm0_recvspace = 16*1024;
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
/*
* user requests
*/
#ifdef FREEBSD_USRREQS
/*
* FreeBSD new usrreqs supersedes pr_usrreq.
*/
Remove __P.
2002-03-20 02:39:27 +00:00
static int natm_usr_attach(struct socket *, int, d_thread_t *);
static int natm_usr_detach(struct socket *);
static int natm_usr_connect(struct socket *, struct sockaddr *, d_thread_t *);
static int natm_usr_disconnect(struct socket *);
static int natm_usr_shutdown(struct socket *);
static int natm_usr_send(struct socket *, int, struct mbuf *,
Style(9): remove unneccesary space and blank lines, indentation, function prototypes. Use LIST_FOREACH instead of explicit loops. The indentation of functions indendet by 4 space have been left alone. 2-space indented functions have been re-indented.
2003-08-06 13:46:15 +00:00
struct sockaddr *, struct mbuf *, d_thread_t *);
Remove __P.
2002-03-20 02:39:27 +00:00
static int natm_usr_peeraddr(struct socket *, struct sockaddr **);
static int natm_usr_control(struct socket *, u_long, caddr_t,
Style(9): remove unneccesary space and blank lines, indentation, function prototypes. Use LIST_FOREACH instead of explicit loops. The indentation of functions indendet by 4 space have been left alone. 2-space indented functions have been re-indented.
2003-08-06 13:46:15 +00:00
struct ifnet *, d_thread_t *);
Remove __P.
2002-03-20 02:39:27 +00:00
static int natm_usr_abort(struct socket *);
static int natm_usr_bind(struct socket *, struct sockaddr *, d_thread_t *);
static int natm_usr_sockaddr(struct socket *, struct sockaddr **);
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
static int
Fix warnings
2002-02-28 03:02:20 +00:00
natm_usr_attach(struct socket *so, int proto, d_thread_t *p)
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
{
struct natmpcb *npcb;
int error = 0;
int s = SPLSOFTNET();
Style(9): remove unneccesary space and blank lines, indentation, function prototypes. Use LIST_FOREACH instead of explicit loops. The indentation of functions indendet by 4 space have been left alone. 2-space indented functions have been re-indented.
2003-08-06 13:46:15 +00:00
npcb = (struct natmpcb *)so->so_pcb;
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
if (npcb) {
error = EISCONN;
goto out;
}
if (so->so_snd.sb_hiwat == 0 || so->so_rcv.sb_hiwat == 0) {
if (proto == PROTO_NATMAAL5)
error = soreserve(so, natm5_sendspace, natm5_recvspace);
else
error = soreserve(so, natm0_sendspace, natm0_recvspace);
if (error)
goto out;
}
Back out M_* changes, per decision of the TRB. Approved by: trb
2003-02-19 05:47:46 +00:00
so->so_pcb = (caddr_t) (npcb = npcb_alloc(M_WAITOK));
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
npcb->npcb_socket = so;
out:
splx(s);
return (error);
}
static int
natm_usr_detach(struct socket *so)
{
struct natmpcb *npcb;
int error = 0;
int s = SPLSOFTNET();
Style(9): remove unneccesary space and blank lines, indentation, function prototypes. Use LIST_FOREACH instead of explicit loops. The indentation of functions indendet by 4 space have been left alone. 2-space indented functions have been re-indented.
2003-08-06 13:46:15 +00:00
npcb = (struct natmpcb *)so->so_pcb;
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
if (npcb == NULL) {
error = EINVAL;
goto out;
}
/*
* we turn on 'drain' *before* we sofree.
*/
npcb_free(npcb, NPCB_DESTROY); /* drain */
Push acquisition of the accept mutex out of sofree() into the caller (sorele()/sotryfree()): - This permits the caller to acquire the accept mutex before the socket mutex, avoiding sofree() having to drop the socket mutex and re-order, which could lead to races permitting more than one thread to enter sofree() after a socket is ready to be free'd. - This also covers clearing of the so_pcb weak socket reference from the protocol to the socket, preventing races in clearing and evaluation of the reference such that sofree() might be called more than once on the same socket. This appears to close a race I was able to easily trigger by repeatedly opening and resetting TCP connections to a host, in which the tcp_close() code called as a result of the RST raced with the close() of the accepted socket in the user process resulting in simultaneous attempts to de-allocate the same socket. The new locking increases the overhead for operations that may potentially free the socket, so we will want to revise the synchronization strategy here as we normalize the reference counting model for sockets. The use of the accept mutex in freeing of sockets that are not listen sockets is primarily motivated by the potential need to remove the socket from the incomplete connection queue on its parent (listen) socket, so cleaning up the reference model here may allow us to substantially weaken the synchronization requirements. RELENG_5_3 candidate. MFC after: 3 days Reviewed by: dwhite Discussed with: gnn, dwhite, green Reported by: Marc UBM Bocklet <ubm at u-boot-man dot de> Reported by: Vlad <marchenko at gmail dot com>
2004-10-18 22:19:43 +00:00
ACCEPT_LOCK();
Extend coverage of SOCK_LOCK(so) to include so_count, the socket reference count: - Assert SOCK_LOCK(so) macros that directly manipulate so_count: soref(), sorele(). - Assert SOCK_LOCK(so) in macros/functions that rely on the state of so_count: sofree(), sotryfree(). - Acquire SOCK_LOCK(so) before calling these functions or macros in various contexts in the stack, both at the socket and protocol layers. - In some cases, perform soisdisconnected() before sotryfree(), as this could result in frobbing of a non-present socket if sotryfree() actually frees the socket. - Note that sofree()/sotryfree() will release the socket lock even if they don't free the socket. Submitted by: sam Sponsored by: FreeBSD Foundation Obtained from: BSD/OS
2004-06-12 20:47:32 +00:00
SOCK_LOCK(so);
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
so->so_pcb = NULL;
Give struct socket structures a ref counting interface similar to vnodes. This will hopefully serve as a base from which we can expand the MP code. We currently do not attempt to obtain any mutex or SX locks, but the door is open to add them when we nail down exactly how that part of it is going to work.
2001-11-17 03:07:11 +00:00
sotryfree(so);
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
out:
splx(s);
return (error);
}
static int
Fix warnings
2002-02-28 03:02:20 +00:00
natm_usr_connect(struct socket *so, struct sockaddr *nam, d_thread_t *p)
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
{
struct natmpcb *npcb;
struct sockaddr_natm *snatm;
Use the new OPENVCC and CLOSEVCC ioctls to open and close the NATM channel. These have been the last consumers of the old ioctls.
2003-08-06 14:07:54 +00:00
struct atmio_openvcc op;
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
struct ifnet *ifp;
int error = 0;
int s2, s = SPLSOFTNET();
int proto = so->so_proto->pr_protocol;
Style(9): remove unneccesary space and blank lines, indentation, function prototypes. Use LIST_FOREACH instead of explicit loops. The indentation of functions indendet by 4 space have been left alone. 2-space indented functions have been re-indented.
2003-08-06 13:46:15 +00:00
npcb = (struct natmpcb *)so->so_pcb;
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
if (npcb == NULL) {
error = EINVAL;
goto out;
}
/*
* validate nam and npcb
*/
Fix all areas of the system (or at least all those in LINT) to avoid storing socket addresses in mbufs. (Socket buffers are the one exception.) A number of kernel APIs needed to get fixed in order to make this happen. Also, fix three protocol families which kept PCBs in mbufs to not malloc them instead. Delete some old compatibility cruft while we're at it, and add some new routines in the in_cksum family.
1997-08-16 19:16:27 +00:00
snatm = (struct sockaddr_natm *)nam;
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
if (snatm->snatm_len != sizeof(*snatm) ||
(npcb->npcb_flags & NPCB_FREE) == 0) {
error = EINVAL;
goto out;
}
if (snatm->snatm_family != AF_NATM) {
error = EAFNOSUPPORT;
goto out;
}
Style(9): remove unneccesary space and blank lines, indentation, function prototypes. Use LIST_FOREACH instead of explicit loops. The indentation of functions indendet by 4 space have been left alone. 2-space indented functions have been re-indented.
2003-08-06 13:46:15 +00:00
snatm->snatm_if[IFNAMSIZ - 1] = '\0'; /* XXX ensure null termination
since ifunit() uses strcmp */
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
/*
* convert interface string to ifp, validate.
*/
ifp = ifunit(snatm->snatm_if);
if (ifp == NULL || (ifp->if_flags & IFF_RUNNING) == 0) {
error = ENXIO;
goto out;
}
if (ifp->if_output != atm_output) {
error = EAFNOSUPPORT;
goto out;
}
/*
* register us with the NATM PCB layer
*/
if (npcb_add(npcb, ifp, snatm->snatm_vci, snatm->snatm_vpi) != npcb) {
error = EADDRINUSE;
goto out;
}
/*
Use the new OPENVCC and CLOSEVCC ioctls to open and close the NATM channel. These have been the last consumers of the old ioctls.
2003-08-06 14:07:54 +00:00
* open the channel
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
*/
Use the new OPENVCC and CLOSEVCC ioctls to open and close the NATM channel. These have been the last consumers of the old ioctls.
2003-08-06 14:07:54 +00:00
bzero(&op, sizeof(op));
op.rxhand = npcb;
op.param.flags = ATMIO_FLAG_PVC;
op.param.vpi = npcb->npcb_vpi;
op.param.vci = npcb->npcb_vci;
op.param.rmtu = op.param.tmtu = ifp->if_mtu;
op.param.aal = (proto == PROTO_NATMAAL5) ? ATMIO_AAL_5 : ATMIO_AAL_0;
op.param.traffic = ATMIO_TRAFFIC_UBR;
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
s2 = splimp();
if (ifp->if_ioctl == NULL ||
Use the new OPENVCC and CLOSEVCC ioctls to open and close the NATM channel. These have been the last consumers of the old ioctls.
2003-08-06 14:07:54 +00:00
ifp->if_ioctl(ifp, SIOCATMOPENVCC, (caddr_t)&op) != 0) {
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
splx(s2);
npcb_free(npcb, NPCB_REMOVE);
error = EIO;
goto out;
}
splx(s2);
soisconnected(so);
out:
splx(s);
return (error);
}
static int
natm_usr_disconnect(struct socket *so)
{
struct natmpcb *npcb;
Use the new OPENVCC and CLOSEVCC ioctls to open and close the NATM channel. These have been the last consumers of the old ioctls.
2003-08-06 14:07:54 +00:00
struct atmio_closevcc cl;
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
struct ifnet *ifp;
int error = 0;
int s2, s = SPLSOFTNET();
Style(9): remove unneccesary space and blank lines, indentation, function prototypes. Use LIST_FOREACH instead of explicit loops. The indentation of functions indendet by 4 space have been left alone. 2-space indented functions have been re-indented.
2003-08-06 13:46:15 +00:00
npcb = (struct natmpcb *)so->so_pcb;
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
if (npcb == NULL) {
error = EINVAL;
goto out;
}
if ((npcb->npcb_flags & NPCB_CONNECTED) == 0) {
printf("natm: disconnected check\n");
error = EIO;
goto out;
}
ifp = npcb->npcb_ifp;
/*
* disable rx
*/
Use the new OPENVCC and CLOSEVCC ioctls to open and close the NATM channel. These have been the last consumers of the old ioctls.
2003-08-06 14:07:54 +00:00
cl.vpi = npcb->npcb_vpi;
cl.vci = npcb->npcb_vci;
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
s2 = splimp();
if (ifp->if_ioctl != NULL)
Use the new OPENVCC and CLOSEVCC ioctls to open and close the NATM channel. These have been the last consumers of the old ioctls.
2003-08-06 14:07:54 +00:00
ifp->if_ioctl(ifp, SIOCATMCLOSEVCC, (caddr_t)&cl);
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
splx(s2);
npcb_free(npcb, NPCB_REMOVE);
soisdisconnected(so);
out:
splx(s);
return (error);
}
static int
natm_usr_shutdown(struct socket *so)
{
socantsendmore(so);
Style(9): remove unneccesary space and blank lines, indentation, function prototypes. Use LIST_FOREACH instead of explicit loops. The indentation of functions indendet by 4 space have been left alone. 2-space indented functions have been re-indented.
2003-08-06 13:46:15 +00:00
return (0);
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
}
static int
Fix all areas of the system (or at least all those in LINT) to avoid storing socket addresses in mbufs. (Socket buffers are the one exception.) A number of kernel APIs needed to get fixed in order to make this happen. Also, fix three protocol families which kept PCBs in mbufs to not malloc them instead. Delete some old compatibility cruft while we're at it, and add some new routines in the in_cksum family.
1997-08-16 19:16:27 +00:00
natm_usr_send(struct socket *so, int flags, struct mbuf *m,
Style(9): remove unneccesary space and blank lines, indentation, function prototypes. Use LIST_FOREACH instead of explicit loops. The indentation of functions indendet by 4 space have been left alone. 2-space indented functions have been re-indented.
2003-08-06 13:46:15 +00:00
struct sockaddr *nam, struct mbuf *control, d_thread_t *p)
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
{
struct natmpcb *npcb;
struct atm_pseudohdr *aph;
int error = 0;
int s = SPLSOFTNET();
int proto = so->so_proto->pr_protocol;
Style(9): remove unneccesary space and blank lines, indentation, function prototypes. Use LIST_FOREACH instead of explicit loops. The indentation of functions indendet by 4 space have been left alone. 2-space indented functions have been re-indented.
2003-08-06 13:46:15 +00:00
npcb = (struct natmpcb *)so->so_pcb;
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
if (npcb == NULL) {
error = EINVAL;
goto out;
}
if (control && control->m_len) {
m_freem(control);
m_freem(m);
error = EINVAL;
goto out;
}
/*
* send the data. we must put an atm_pseudohdr on first
*/
Back out M_* changes, per decision of the TRB. Approved by: trb
2003-02-19 05:47:46 +00:00
M_PREPEND(m, sizeof(*aph), M_TRYWAIT);
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
if (m == NULL) {
error = ENOBUFS;
goto out;
}
aph = mtod(m, struct atm_pseudohdr *);
ATM_PH_VPI(aph) = npcb->npcb_vpi;
ATM_PH_SETVCI(aph, npcb->npcb_vci);
ATM_PH_FLAGS(aph) = (proto == PROTO_NATMAAL5) ? ATM_PH_AAL5 : 0;
error = atm_output(npcb->npcb_ifp, m, NULL, NULL);
out:
splx(s);
return (error);
}
static int
Fix all areas of the system (or at least all those in LINT) to avoid storing socket addresses in mbufs. (Socket buffers are the one exception.) A number of kernel APIs needed to get fixed in order to make this happen. Also, fix three protocol families which kept PCBs in mbufs to not malloc them instead. Delete some old compatibility cruft while we're at it, and add some new routines in the in_cksum family.
1997-08-16 19:16:27 +00:00
natm_usr_peeraddr(struct socket *so, struct sockaddr **nam)
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
{
struct natmpcb *npcb;
Fix all areas of the system (or at least all those in LINT) to avoid storing socket addresses in mbufs. (Socket buffers are the one exception.) A number of kernel APIs needed to get fixed in order to make this happen. Also, fix three protocol families which kept PCBs in mbufs to not malloc them instead. Delete some old compatibility cruft while we're at it, and add some new routines in the in_cksum family.
1997-08-16 19:16:27 +00:00
struct sockaddr_natm *snatm, ssnatm;
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
int error = 0;
int s = SPLSOFTNET();
Style(9): remove unneccesary space and blank lines, indentation, function prototypes. Use LIST_FOREACH instead of explicit loops. The indentation of functions indendet by 4 space have been left alone. 2-space indented functions have been re-indented.
2003-08-06 13:46:15 +00:00
npcb = (struct natmpcb *)so->so_pcb;
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
if (npcb == NULL) {
error = EINVAL;
goto out;
}
Fix all areas of the system (or at least all those in LINT) to avoid storing socket addresses in mbufs. (Socket buffers are the one exception.) A number of kernel APIs needed to get fixed in order to make this happen. Also, fix three protocol families which kept PCBs in mbufs to not malloc them instead. Delete some old compatibility cruft while we're at it, and add some new routines in the in_cksum family.
1997-08-16 19:16:27 +00:00
snatm = &ssnatm;
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
bzero(snatm, sizeof(*snatm));
Fix all areas of the system (or at least all those in LINT) to avoid storing socket addresses in mbufs. (Socket buffers are the one exception.) A number of kernel APIs needed to get fixed in order to make this happen. Also, fix three protocol families which kept PCBs in mbufs to not malloc them instead. Delete some old compatibility cruft while we're at it, and add some new routines in the in_cksum family.
1997-08-16 19:16:27 +00:00
snatm->snatm_len = sizeof(*snatm);
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
snatm->snatm_family = AF_NATM;
Replace the if_name and if_unit members of struct ifnet with new members if_xname, if_dname, and if_dunit. if_xname is the name of the interface and if_dname/unit are the driver name and instance. This change paves the way for interface renaming and enhanced pseudo device creation and configuration symantics. Approved By: re (in principle) Reviewed By: njl, imp Tested On: i386, amd64, sparc64 Obtained From: NetBSD (if_xname)
2003-10-31 18:32:15 +00:00
strlcpy(snatm->snatm_if, npcb->npcb_ifp->if_xname,
sizeof(snatm->snatm_if));
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
snatm->snatm_vci = npcb->npcb_vci;
snatm->snatm_vpi = npcb->npcb_vpi;
Rename dup_sockaddr() to sodupsockaddr() for consistency with other functions in kern_socket.c. Rename the "canwait" field to "mflags" and pass M_WAITOK and M_NOWAIT in from the caller context rather than "1" or "0". Correct mflags pass into mac_init_socket() from previous commit to not include M_ZERO. Submitted by: sam
2004-03-01 03:14:23 +00:00
*nam = sodupsockaddr((struct sockaddr *)snatm, M_NOWAIT);
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
out:
splx(s);
return (error);
}
static int
This commit fixes various 64bit portability problems required for FreeBSD/alpha. The most significant item is to change the command argument to ioctl functions from int to u_long. This change brings us inline with various other BSD versions. Driver writers may like to use (__FreeBSD_version == 300003) to detect this change. The prototype FreeBSD/alpha machdep will follow in a couple of days time.
1998-06-07 17:13:14 +00:00
natm_usr_control(struct socket *so, u_long cmd, caddr_t arg,
Style(9): remove unneccesary space and blank lines, indentation, function prototypes. Use LIST_FOREACH instead of explicit loops. The indentation of functions indendet by 4 space have been left alone. 2-space indented functions have been re-indented.
2003-08-06 13:46:15 +00:00
struct ifnet *ifp, d_thread_t *p)
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
{
struct natmpcb *npcb;
int error = 0;
int s = SPLSOFTNET();
Style(9): remove unneccesary space and blank lines, indentation, function prototypes. Use LIST_FOREACH instead of explicit loops. The indentation of functions indendet by 4 space have been left alone. 2-space indented functions have been re-indented.
2003-08-06 13:46:15 +00:00
npcb = (struct natmpcb *)so->so_pcb;
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
if (npcb == NULL) {
error = EINVAL;
goto out;
}
Remove the last vestiges of ATM raw mode. This has not been useful for a long time and has already been removed from the only driver that supported it (en(4)) and from the man page.
2003-08-06 14:34:38 +00:00
splx(s);
if (ifp == NULL || ifp->if_ioctl == NULL) {
error = EOPNOTSUPP;
goto out;
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
}
Remove the last vestiges of ATM raw mode. This has not been useful for a long time and has already been removed from the only driver that supported it (en(4)) and from the man page.
2003-08-06 14:34:38 +00:00
return ((*ifp->if_ioctl)(ifp, cmd, arg));
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
out:
splx(s);
return (error);
}
static int
natm_usr_abort(struct socket *so)
{
Style(9): remove unneccesary space and blank lines, indentation, function prototypes. Use LIST_FOREACH instead of explicit loops. The indentation of functions indendet by 4 space have been left alone. 2-space indented functions have been re-indented.
2003-08-06 13:46:15 +00:00
return (natm_usr_shutdown(so));
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
}
static int
Fix warnings
2002-02-28 03:02:20 +00:00
natm_usr_bind(struct socket *so, struct sockaddr *nam, d_thread_t *p)
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
{
Style(9): remove unneccesary space and blank lines, indentation, function prototypes. Use LIST_FOREACH instead of explicit loops. The indentation of functions indendet by 4 space have been left alone. 2-space indented functions have been re-indented.
2003-08-06 13:46:15 +00:00
return (EOPNOTSUPP);
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
}
static int
Fix all areas of the system (or at least all those in LINT) to avoid storing socket addresses in mbufs. (Socket buffers are the one exception.) A number of kernel APIs needed to get fixed in order to make this happen. Also, fix three protocol families which kept PCBs in mbufs to not malloc them instead. Delete some old compatibility cruft while we're at it, and add some new routines in the in_cksum family.
1997-08-16 19:16:27 +00:00
natm_usr_sockaddr(struct socket *so, struct sockaddr **nam)
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
{
Style(9): remove unneccesary space and blank lines, indentation, function prototypes. Use LIST_FOREACH instead of explicit loops. The indentation of functions indendet by 4 space have been left alone. 2-space indented functions have been re-indented.
2003-08-06 13:46:15 +00:00
return (EOPNOTSUPP);
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
}
/* xxx - should be const */
struct pr_usrreqs natm_usrreqs = {
Initialize struct pr_userreqs in new/sparse style and fill in common default elements in net_init_domain(). This makes it possible to grep these structures and see any bogosities.
2004-11-08 14:44:54 +00:00
.pru_abort = natm_usr_abort,
.pru_attach = natm_usr_attach,
.pru_bind = natm_usr_bind,
.pru_connect = natm_usr_connect,
.pru_control = natm_usr_control,
.pru_detach = natm_usr_detach,
.pru_disconnect = natm_usr_disconnect,
.pru_peeraddr = natm_usr_peeraddr,
.pru_send = natm_usr_send,
.pru_shutdown = natm_usr_shutdown,
.pru_sockaddr = natm_usr_sockaddr,
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
};
#else /* !FREEBSD_USRREQS */
#if defined(__NetBSD__) || defined(__OpenBSD__)
int natm_usrreq(so, req, m, nam, control, p)
#elif defined(__FreeBSD__)
int natm_usrreq(so, req, m, nam, control)
#endif
struct socket *so;
int req;
struct mbuf *m, *nam, *control;
#if defined(__NetBSD__) || defined(__OpenBSD__)
struct proc *p;
#endif
{
int error = 0, s, s2;
struct natmpcb *npcb;
struct sockaddr_natm *snatm;
struct atm_pseudoioctl api;
struct atm_pseudohdr *aph;
struct atm_rawioctl ario;
struct ifnet *ifp;
int proto = so->so_proto->pr_protocol;
s = SPLSOFTNET();
npcb = (struct natmpcb *) so->so_pcb;
if (npcb == NULL && req != PRU_ATTACH) {
error = EINVAL;
goto done;
}
switch (req) {
case PRU_ATTACH: /* attach protocol to up */
if (npcb) {
error = EISCONN;
break;
}
if (so->so_snd.sb_hiwat == 0 || so->so_rcv.sb_hiwat == 0) {
if (proto == PROTO_NATMAAL5)
error = soreserve(so, natm5_sendspace, natm5_recvspace);
else
error = soreserve(so, natm0_sendspace, natm0_recvspace);
if (error)
break;
}
Back out M_* changes, per decision of the TRB. Approved by: trb
2003-02-19 05:47:46 +00:00
so->so_pcb = (caddr_t) (npcb = npcb_alloc(M_WAITOK));
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
npcb->npcb_socket = so;
break;
case PRU_DETACH: /* detach protocol from up */
/*
* we turn on 'drain' *before* we sofree.
*/
npcb_free(npcb, NPCB_DESTROY); /* drain */
Push acquisition of the accept mutex out of sofree() into the caller (sorele()/sotryfree()): - This permits the caller to acquire the accept mutex before the socket mutex, avoiding sofree() having to drop the socket mutex and re-order, which could lead to races permitting more than one thread to enter sofree() after a socket is ready to be free'd. - This also covers clearing of the so_pcb weak socket reference from the protocol to the socket, preventing races in clearing and evaluation of the reference such that sofree() might be called more than once on the same socket. This appears to close a race I was able to easily trigger by repeatedly opening and resetting TCP connections to a host, in which the tcp_close() code called as a result of the RST raced with the close() of the accepted socket in the user process resulting in simultaneous attempts to de-allocate the same socket. The new locking increases the overhead for operations that may potentially free the socket, so we will want to revise the synchronization strategy here as we normalize the reference counting model for sockets. The use of the accept mutex in freeing of sockets that are not listen sockets is primarily motivated by the potential need to remove the socket from the incomplete connection queue on its parent (listen) socket, so cleaning up the reference model here may allow us to substantially weaken the synchronization requirements. RELENG_5_3 candidate. MFC after: 3 days Reviewed by: dwhite Discussed with: gnn, dwhite, green Reported by: Marc UBM Bocklet <ubm at u-boot-man dot de> Reported by: Vlad <marchenko at gmail dot com>
2004-10-18 22:19:43 +00:00
ACCEPT_LOCK();
Extend coverage of SOCK_LOCK(so) to include so_count, the socket reference count: - Assert SOCK_LOCK(so) macros that directly manipulate so_count: soref(), sorele(). - Assert SOCK_LOCK(so) in macros/functions that rely on the state of so_count: sofree(), sotryfree(). - Acquire SOCK_LOCK(so) before calling these functions or macros in various contexts in the stack, both at the socket and protocol layers. - In some cases, perform soisdisconnected() before sotryfree(), as this could result in frobbing of a non-present socket if sotryfree() actually frees the socket. - Note that sofree()/sotryfree() will release the socket lock even if they don't free the socket. Submitted by: sam Sponsored by: FreeBSD Foundation Obtained from: BSD/OS
2004-06-12 20:47:32 +00:00
SOCK_LOCK(so);
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
so->so_pcb = NULL;
Give struct socket structures a ref counting interface similar to vnodes. This will hopefully serve as a base from which we can expand the MP code. We currently do not attempt to obtain any mutex or SX locks, but the door is open to add them when we nail down exactly how that part of it is going to work.
2001-11-17 03:07:11 +00:00
sotryfree(so);
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
break;
case PRU_CONNECT: /* establish connection to peer */
/*
* validate nam and npcb
*/
if (nam->m_len != sizeof(*snatm)) {
error = EINVAL;
break;
}
snatm = mtod(nam, struct sockaddr_natm *);
if (snatm->snatm_len != sizeof(*snatm) ||
(npcb->npcb_flags & NPCB_FREE) == 0) {
error = EINVAL;
break;
}
if (snatm->snatm_family != AF_NATM) {
error = EAFNOSUPPORT;
break;
}
snatm->snatm_if[IFNAMSIZ-1] = '\0'; /* XXX ensure null termination
since ifunit() uses strcmp */
/*
* convert interface string to ifp, validate.
*/
ifp = ifunit(snatm->snatm_if);
if (ifp == NULL || (ifp->if_flags & IFF_RUNNING) == 0) {
error = ENXIO;
break;
}
if (ifp->if_output != atm_output) {
error = EAFNOSUPPORT;
break;
}
/*
* register us with the NATM PCB layer
*/
if (npcb_add(npcb, ifp, snatm->snatm_vci, snatm->snatm_vpi) != npcb) {
error = EADDRINUSE;
break;
}
/*
* enable rx
*/
ATM_PH_FLAGS(&api.aph) = (proto == PROTO_NATMAAL5) ? ATM_PH_AAL5 : 0;
ATM_PH_VPI(&api.aph) = npcb->npcb_vpi;
ATM_PH_SETVCI(&api.aph, npcb->npcb_vci);
api.rxhand = npcb;
s2 = splimp();
if (ifp->if_ioctl == NULL ||
ifp->if_ioctl(ifp, SIOCATMENA, (caddr_t) &api) != 0) {
splx(s2);
npcb_free(npcb, NPCB_REMOVE);
error = EIO;
break;
}
splx(s2);
soisconnected(so);
break;
case PRU_DISCONNECT: /* disconnect from peer */
if ((npcb->npcb_flags & NPCB_CONNECTED) == 0) {
printf("natm: disconnected check\n");
error = EIO;
break;
}
ifp = npcb->npcb_ifp;
/*
* disable rx
*/
ATM_PH_FLAGS(&api.aph) = ATM_PH_AAL5;
ATM_PH_VPI(&api.aph) = npcb->npcb_vpi;
ATM_PH_SETVCI(&api.aph, npcb->npcb_vci);
api.rxhand = npcb;
s2 = splimp();
if (ifp->if_ioctl != NULL)
ifp->if_ioctl(ifp, SIOCATMDIS, (caddr_t) &api);
splx(s2);
npcb_free(npcb, NPCB_REMOVE);
soisdisconnected(so);
break;
case PRU_SHUTDOWN: /* won't send any more data */
socantsendmore(so);
break;
case PRU_SEND: /* send this data */
if (control && control->m_len) {
m_freem(control);
m_freem(m);
error = EINVAL;
break;
}
/*
* send the data. we must put an atm_pseudohdr on first
*/
Back out M_* changes, per decision of the TRB. Approved by: trb
2003-02-19 05:47:46 +00:00
M_PREPEND(m, sizeof(*aph), M_TRYWAIT);
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
if (m == NULL) {
error = ENOBUFS;
break;
}
aph = mtod(m, struct atm_pseudohdr *);
ATM_PH_VPI(aph) = npcb->npcb_vpi;
ATM_PH_SETVCI(aph, npcb->npcb_vci);
ATM_PH_FLAGS(aph) = (proto == PROTO_NATMAAL5) ? ATM_PH_AAL5 : 0;
error = atm_output(npcb->npcb_ifp, m, NULL, NULL);
break;
case PRU_SENSE: /* return status into m */
/* return zero? */
break;
case PRU_PEERADDR: /* fetch peer's address */
snatm = mtod(nam, struct sockaddr_natm *);
bzero(snatm, sizeof(*snatm));
nam->m_len = snatm->snatm_len = sizeof(*snatm);
snatm->snatm_family = AF_NATM;
#if defined(__NetBSD__) || defined(__OpenBSD__)
bcopy(npcb->npcb_ifp->if_xname, snatm->snatm_if, sizeof(snatm->snatm_if));
#elif defined(__FreeBSD__)
Examine all occurrences of sprintf(), strcat(), and str[n]cpy() for possible buffer overflow problems. Replaced most sprintf()'s with snprintf(); for others cases, added terminating NUL bytes where appropriate, replaced constants like "16" with sizeof(), etc. These changes include several bug fixes, but most changes are for maintainability's sake. Any instance where it wasn't "immediately obvious" that a buffer overflow could not occur was made safer. Reviewed by: Bruce Evans <bde@zeta.org.au> Reviewed by: Matthew Dillon <dillon@apollo.backplane.com> Reviewed by: Mike Spengler <mks@networkcs.com>
1998-12-04 22:54:57 +00:00
snprintf(snatm->snatm_if, sizeof(snatm->snatm_if),
"%s%d", npcb->npcb_ifp->if_name, npcb->npcb_ifp->if_unit);
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
#endif
snatm->snatm_vci = npcb->npcb_vci;
snatm->snatm_vpi = npcb->npcb_vpi;
break;
case PRU_CONTROL: /* control operations on protocol */
/*
* raw atm ioctl. comes in as a SIOCRAWATM. we convert it to
* SIOCXRAWATM and pass it to the driver.
*/
if ((u_long)m == SIOCRAWATM) {
if (npcb->npcb_ifp == NULL) {
error = ENOTCONN;
break;
}
ario.npcb = npcb;
ario.rawvalue = *((int *)nam);
error = npcb->npcb_ifp->if_ioctl(npcb->npcb_ifp,
SIOCXRAWATM, (caddr_t) &ario);
if (!error) {
if (ario.rawvalue)
npcb->npcb_flags |= NPCB_RAW;
else
npcb->npcb_flags &= ~(NPCB_RAW);
}
break;
}
error = EOPNOTSUPP;
break;
case PRU_BIND: /* bind socket to address */
case PRU_LISTEN: /* listen for connection */
case PRU_ACCEPT: /* accept connection from peer */
case PRU_CONNECT2: /* connect two sockets */
case PRU_ABORT: /* abort (fast DISCONNECT, DETATCH) */
/* (only happens if LISTEN socket) */
case PRU_RCVD: /* have taken data; more room now */
case PRU_FASTTIMO: /* 200ms timeout */
case PRU_SLOWTIMO: /* 500ms timeout */
case PRU_RCVOOB: /* retrieve out of band data */
case PRU_SENDOOB: /* send out of band data */
case PRU_PROTORCV: /* receive from below */
case PRU_PROTOSEND: /* send to below */
case PRU_SOCKADDR: /* fetch socket's address */
#ifdef DIAGNOSTIC
printf("natm: PRU #%d unsupported\n", req);
#endif
error = EOPNOTSUPP;
break;
default: panic("natm usrreq");
}
done:
splx(s);
return(error);
}
#endif /* !FREEBSD_USRREQS */
/*
* natmintr: splsoftnet interrupt
*
* note: we expect a socket pointer in rcvif rather than an interface
* pointer. we can get the interface pointer from the so's PCB if
* we really need it.
*/
void
Update netisr handling; Each SWI now registers its queue, and all queue drain routines are done by swi_net, which allows for better queue control at some future point. Packets may also be directly dispatched to a netisr instead of queued, this may be of interest at some installations, but currently defaults to off. Reviewed by: hsu, silby, jayanth, sam Sponsored by: DARPA, NAI Labs
2003-03-04 23:19:55 +00:00
natmintr(struct mbuf *m)
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
{
Style(9): remove unneccesary space and blank lines, indentation, function prototypes. Use LIST_FOREACH instead of explicit loops. The indentation of functions indendet by 4 space have been left alone. 2-space indented functions have been re-indented.
2003-08-06 13:46:15 +00:00
int s;
struct socket *so;
struct natmpcb *npcb;
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
o add a flags parameter to netisr_register that is used to specify whether or not the isr needs to hold Giant when running; Giant-less operation is also controlled by the setting of debug_mpsafenet o mark all netisr's except NETISR_IP as needing Giant o add a GIANT_REQUIRED assertion to the top of netisr's that need Giant o pickup Giant (when debug_mpsafenet is 1) inside ip_input before calling up with a packet o change netisr handling so swi_net runs w/o Giant; instead we grab Giant before invoking handlers based on whether the handler needs Giant o change netisr handling so that netisr's that are marked MPSAFE may have multiple instances active at a time o add netisr statistics for packets dropped because the isr is inactive Supported by: FreeBSD Foundation
2003-11-08 22:28:40 +00:00
GIANT_REQUIRED;
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
#ifdef DIAGNOSTIC
Style(9): remove unneccesary space and blank lines, indentation, function prototypes. Use LIST_FOREACH instead of explicit loops. The indentation of functions indendet by 4 space have been left alone. 2-space indented functions have been re-indented.
2003-08-06 13:46:15 +00:00
M_ASSERTPKTHDR(m);
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
#endif
Style(9): remove unneccesary space and blank lines, indentation, function prototypes. Use LIST_FOREACH instead of explicit loops. The indentation of functions indendet by 4 space have been left alone. 2-space indented functions have been re-indented.
2003-08-06 13:46:15 +00:00
npcb = (struct natmpcb *)m->m_pkthdr.rcvif; /* XXX: overloaded */
so = npcb->npcb_socket;
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
Style(9): remove unneccesary space and blank lines, indentation, function prototypes. Use LIST_FOREACH instead of explicit loops. The indentation of functions indendet by 4 space have been left alone. 2-space indented functions have been re-indented.
2003-08-06 13:46:15 +00:00
s = splimp(); /* could have atm devs @ different levels */
npcb->npcb_inq--;
splx(s);
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
Style(9): remove unneccesary space and blank lines, indentation, function prototypes. Use LIST_FOREACH instead of explicit loops. The indentation of functions indendet by 4 space have been left alone. 2-space indented functions have been re-indented.
2003-08-06 13:46:15 +00:00
if (npcb->npcb_flags & NPCB_DRAIN) {
m_freem(m);
if (npcb->npcb_inq == 0)
FREE(npcb, M_PCB); /* done! */
return;
}
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
Style(9): remove unneccesary space and blank lines, indentation, function prototypes. Use LIST_FOREACH instead of explicit loops. The indentation of functions indendet by 4 space have been left alone. 2-space indented functions have been re-indented.
2003-08-06 13:46:15 +00:00
if (npcb->npcb_flags & NPCB_FREE) {
m_freem(m); /* drop */
return;
}
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
#ifdef NEED_TO_RESTORE_IFP
Style(9): remove unneccesary space and blank lines, indentation, function prototypes. Use LIST_FOREACH instead of explicit loops. The indentation of functions indendet by 4 space have been left alone. 2-space indented functions have been re-indented.
2003-08-06 13:46:15 +00:00
m->m_pkthdr.rcvif = npcb->npcb_ifp;
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
#else
#ifdef DIAGNOSTIC
Style(9): remove unneccesary space and blank lines, indentation, function prototypes. Use LIST_FOREACH instead of explicit loops. The indentation of functions indendet by 4 space have been left alone. 2-space indented functions have been re-indented.
2003-08-06 13:46:15 +00:00
m->m_pkthdr.rcvif = NULL; /* null it out to be safe */
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
#endif
#endif
Remove the last vestiges of ATM raw mode. This has not been useful for a long time and has already been removed from the only driver that supported it (en(4)) and from the man page.
2003-08-06 14:34:38 +00:00
if (sbspace(&so->so_rcv) > m->m_pkthdr.len) {
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
#ifdef NATM_STAT
Style(9): remove unneccesary space and blank lines, indentation, function prototypes. Use LIST_FOREACH instead of explicit loops. The indentation of functions indendet by 4 space have been left alone. 2-space indented functions have been re-indented.
2003-08-06 13:46:15 +00:00
natm_sookcnt++;
natm_sookbytes += m->m_pkthdr.len;
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
#endif
Style(9): remove unneccesary space and blank lines, indentation, function prototypes. Use LIST_FOREACH instead of explicit loops. The indentation of functions indendet by 4 space have been left alone. 2-space indented functions have been re-indented.
2003-08-06 13:46:15 +00:00
sbappendrecord(&so->so_rcv, m);
sorwakeup(so);
} else {
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
#ifdef NATM_STAT
Style(9): remove unneccesary space and blank lines, indentation, function prototypes. Use LIST_FOREACH instead of explicit loops. The indentation of functions indendet by 4 space have been left alone. 2-space indented functions have been re-indented.
2003-08-06 13:46:15 +00:00
natm_sodropcnt++;
natm_sodropbytes += m->m_pkthdr.len;
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
#endif
Style(9): remove unneccesary space and blank lines, indentation, function prototypes. Use LIST_FOREACH instead of explicit loops. The indentation of functions indendet by 4 space have been left alone. 2-space indented functions have been re-indented.
2003-08-06 13:46:15 +00:00
m_freem(m);
}
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
}
/*
* natm0_sysctl: not used, but here in case we want to add something
* later...
*/
Style(9): remove unneccesary space and blank lines, indentation, function prototypes. Use LIST_FOREACH instead of explicit loops. The indentation of functions indendet by 4 space have been left alone. 2-space indented functions have been re-indented.
2003-08-06 13:46:15 +00:00
int
natm0_sysctl(SYSCTL_HANDLER_ARGS)
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
{
Style(9): remove unneccesary space and blank lines, indentation, function prototypes. Use LIST_FOREACH instead of explicit loops. The indentation of functions indendet by 4 space have been left alone. 2-space indented functions have been re-indented.
2003-08-06 13:46:15 +00:00
/* All sysctl names at this level are terminal. */
return (ENOENT);
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
}
/*
* natm5_sysctl: not used, but here in case we want to add something
* later...
*/
Style(9): remove unneccesary space and blank lines, indentation, function prototypes. Use LIST_FOREACH instead of explicit loops. The indentation of functions indendet by 4 space have been left alone. 2-space indented functions have been re-indented.
2003-08-06 13:46:15 +00:00
int
natm5_sysctl(SYSCTL_HANDLER_ARGS)
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
{
Style(9): remove unneccesary space and blank lines, indentation, function prototypes. Use LIST_FOREACH instead of explicit loops. The indentation of functions indendet by 4 space have been left alone. 2-space indented functions have been re-indented.
2003-08-06 13:46:15 +00:00
/* All sysctl names at this level are terminal. */
return (ENOENT);
import Chuck Cranor's ATM driver
1997-05-09 08:04:59 +00:00
}
Reference in New Issue Copy Permalink