cleandir: Fix ESTALE errors from parallel removals.
This fixes 'make cleandir' to use the same ordering as 'make cleanobj'. Meaning that SUBDIR will be recursed before the current directory is handled. This avoids an 'rm -rf /usr/obj/usr/src/lib/libc' while a child 'rm -rf /usr/obj/usr/src/lib/libc/tests' is being ran next, or even removing the current directory and then recursing into a child and using the 'missing OBJDIR' logic to remove files rather than the directory. The most ideal ordering here would be for 'cleanobj' and 'cleandir' to simply remove the .OBJDIR and then not recurse at all. This is only safe if it is guaranteed that all children directories have no orphaned files in their source checkout and are only using obj directories. This is usually safe from the top-level build targets and when using WITH_AUTO_OBJ. Improving the build for those cases is coming. Reported by: cperciva, scottl X-MFC-With: r321427 MFC after: 2 weeks Sponsored by: Dell EMC Isilon
This commit is contained in:
parent
e017348aa8
commit
01ba2b6319
Notes:
svn2git
2020-12-20 02:59:44 +00:00
svn path=/head/; revision=321445
@ -183,10 +183,10 @@ clean:
|
||||
.endif
|
||||
.ORDER: clean all
|
||||
|
||||
cleandir: cleanobj
|
||||
|
||||
.include <bsd.subdir.mk>
|
||||
|
||||
cleandir: .WAIT cleanobj
|
||||
|
||||
.if make(destroy*) && defined(OBJROOT)
|
||||
# this (rm -rf objdir) is much faster and more reliable than cleaning.
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user