Remove the PAWS ack-on-ack debugging printf().
Note that the original RFC 1323 (PAWS) says in 4.2.1 that the out of order / reverse-time-indexed packet should be acknowledged as specified in RFC-793 page 69 then dropped. The original PAWS code in FreeBSD (1994) simply acknowledged the segment unconditionally, which is incorrect, and was fixed in 1.183 (2002). At the moment we do not do checks for SYN or FIN in addition to (tlen != 0), which may or may not be correct, but the worst that ought to happen should be a retry by the sender.
This commit is contained in:
parent
ba04519ba3
commit
07fd333df3
Notes:
svn2git
2020-12-20 02:59:44 +00:00
svn path=/head/; revision=108464
@ -1454,12 +1454,9 @@ tcp_input(m, off0)
|
||||
tcpstat.tcps_rcvduppack++;
|
||||
tcpstat.tcps_rcvdupbyte += tlen;
|
||||
tcpstat.tcps_pawsdrop++;
|
||||
if (tlen) {
|
||||
if (tlen)
|
||||
goto dropafterack;
|
||||
} else {
|
||||
printf("PAWS ack-on-ack loop avoided\n");
|
||||
goto drop;
|
||||
}
|
||||
goto drop;
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -1454,12 +1454,9 @@ tcp_input(m, off0)
|
||||
tcpstat.tcps_rcvduppack++;
|
||||
tcpstat.tcps_rcvdupbyte += tlen;
|
||||
tcpstat.tcps_pawsdrop++;
|
||||
if (tlen) {
|
||||
if (tlen)
|
||||
goto dropafterack;
|
||||
} else {
|
||||
printf("PAWS ack-on-ack loop avoided\n");
|
||||
goto drop;
|
||||
}
|
||||
goto drop;
|
||||
}
|
||||
}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user