d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Clarify the reason to not use the volatile string as an argument to CTR

Browse Source 
macros. Note the logging of file and line.

Reviewed by:	dchagin
MFC after:	3 days
This commit is contained in:
Konstantin Belousov 2008-11-30 13:18:35 +00:00
parent 499062187b
commit 0886d6e46b
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=185474
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
share/man/man9/ktr.9
View File

@ -24,7 +24,7 @@
.\"
.\" $FreeBSD$
.\"
.Dd December 27, 2005
.Dd November 30, 2008
.Dt KTR 9
.Os
.Sh NAME
@ -84,9 +84,16 @@ Following the
.Fa format
string are zero to five arguments referenced by
.Fa format .
Each event is logged with a file name and source line number of the
originating CTR call, and a timestamp in addition to the log message.
.Pp
The event is stored in the circular buffer with supplied arguments as is,
and formatting is done at the dump time.
Do not use pointers to the objects with limited lifetime, for instance,
strings, because the pointer may become invalid when buffer is printed.
.Pp
Note that the different macros differ only in the number of arguments each
one takes, as indicated by its name.
Each event is logged with a timestamp in addition to the log message.
.Pp
The
.Va ktr_entries
@ -121,13 +128,11 @@ mi_switch()
* Pick a new current process and record its start time.
*/
...
CTR3(KTR_PROC, "mi_switch: old proc %p (pid %d, %s)", p, p->p_pid,
p->p_comm);
CTR3(KTR_PROC, "mi_switch: old proc %p (pid %d)", p, p->p_pid);
...
cpu_switch();
...
CTR3(KTR_PROC, "mi_switch: new proc %p (pid %d, %s)", p, p->p_pid,
p->p_comm);
CTR3(KTR_PROC, "mi_switch: new proc %p (pid %d)", p, p->p_pid);
...
}
.Ed