d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

if_awg: only increment IFCOUNTER_OPACKETS when the last segment of a frame has been successfully transmitted

Browse Source 
A packet may be built from multiple segments, don't increase the count for each segment

Submitted by:	Guy Yur <guyyur@gmail.com>
Differential Revision:	https://reviews.freebsd.org/D13032
This commit is contained in:
Emmanuel Vadot 2017-11-18 20:50:31 +00:00
parent fce9d29f8d
commit 09e2285c4c
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=325980
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
sys/arm/allwinner/if_awg.c
View File

@ -914,7 +914,7 @@ static void
awg_txintr(struct awg_softc *sc)
{
struct emac_desc *desc;
uint32_t status;
uint32_t status, size;
if_t ifp;
int i;
@ -929,9 +929,15 @@ awg_txintr(struct awg_softc *sc)
status = le32toh(desc->status);
if ((status & TX_DESC_CTL) != 0)
break;
size = le32toh(desc->size);
if (size & TX_LAST_DESC) {
if ((status & (TX_HEADER_ERR | TX_PAYLOAD_ERR)) != 0)
if_inc_counter(ifp, IFCOUNTER_OERRORS, 1);
else
if_inc_counter(ifp, IFCOUNTER_OPACKETS, 1);
}
awg_clean_txbuf(sc, i);
if_setdrvflagbits(ifp, 0, IFF_DRV_OACTIVE);
if_inc_counter(ifp, IFCOUNTER_OPACKETS, 1);
}
sc->tx.next = i;