d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

rctl: fix sysctl kern.racct.enable use after r341182

Browse Source 
The value was changed from int to bool. Since the new type
is smaller, the rest of the variable in the caller was left
unitialized.

PR:		236714
Reported by:	trasz
Diagnosed by:	markj
Sponsored by:	The FreeBSD Foundation
This commit is contained in:
Mateusz Guzik 2019-04-03 20:37:14 +00:00
parent fd29ff5d53
commit 0a17b9e03e
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=345853
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
usr.bin/rctl/rctl.c
View File

@ -378,8 +378,9 @@ print_rules(char *rules, int hflag, int nflag)
static void
enosys(void)
{
int error, racct_enable;
size_t racct_enable_len;
int error;
bool racct_enable;
racct_enable_len = sizeof(racct_enable);
error = sysctlbyname("kern.racct.enable",
@ -392,7 +393,7 @@ enosys(void)
err(1, "sysctlbyname");
}
if (racct_enable == 0)
if (!racct_enable)
errx(1, "RACCT/RCTL present, but disabled; enable using kern.racct.enable=1 tunable");
}