d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use ipfw runtime lock only when real modification is required.

Browse Source
This commit is contained in:
Alexander V. Chernikov 2015-01-16 10:49:27 +00:00
parent 828a2d9e5a
commit 0b47e42b49
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=277240
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sys/netpfil/ipfw/ip_fw_nat.c
View File

@ -105,7 +105,7 @@ ifaddr_change(void *arg __unused, struct ifnet *ifp)
KASSERT(curvnet == ifp->if_vnet,
("curvnet(%p) differs from iface vnet(%p)", curvnet, ifp->if_vnet));
chain = &V_layer3_chain;
IPFW_WLOCK(chain);
IPFW_UH_WLOCK(chain);
/* Check every nat entry... */
LIST_FOREACH(ptr, &chain->nat, _next) {
/* ...using nic 'ifp->if_xname' as dynamic alias address. */
@ -117,13 +117,15 @@ ifaddr_change(void *arg __unused, struct ifnet *ifp)
continue;
if (ifa->ifa_addr->sa_family != AF_INET)
continue;
IPFW_WLOCK(chain);
ptr->ip = ((struct sockaddr_in *)
(ifa->ifa_addr))->sin_addr;
LibAliasSetAddress(ptr->lib, ptr->ip);
IPFW_WUNLOCK(chain);
}
if_addr_runlock(ifp);
}
IPFW_WUNLOCK(chain);
IPFW_UH_WUNLOCK(chain);
}
/*