d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libstand: Reset the seek pointer in ext2fs as done in UFS.

Browse Source 
Based on r134760:

Reset the seek pointer to 0 when a file is successfully opened,
since otherwise the initial seek offset will contain the directory
offset of the filesystem block that contained its directory entry.
This bug was mostly harmless because typically the directory is
less than one filesystem block in size so the offset would be zero.
It did however generally break loading a kernel from the (large)
kernel compile directory.

Also reset the seek pointer when a new inode is opened in read_inode(),
though this is not actually necessary now because all callers set
it afterwards.

PR:		177328
Submitted by:	Eric van Gyzen
Reviewed by:	iedowse
MFC after:	5 days
This commit is contained in:
Pedro F. Giffuni 2013-06-09 01:19:22 +00:00
parent 8ad6d9175c
commit 0b4b96e6e5
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=251561
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/libstand/ext2fs.c
View File

@ -536,6 +536,7 @@ ext2fs_open(const char *upath, struct open_file *f)
* Found terminal component.
*/
error = 0;
fp->f_seekp = 0;
out:
if (buf)
free(buf);
@ -584,6 +585,7 @@ read_inode(ino_t inumber, struct open_file *f)
for (level = 0; level < NIADDR; level++)
fp->f_blkno[level] = -1;
fp->f_buf_blkno = -1;
fp->f_seekp = 0;
out:
free(buf);