d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Set the FD_CLOEXEC flag on the open pidfile file descriptor.

Browse Source 
Discussed with: pjd, des
This commit is contained in:
Guy Helmer 2012-01-10 18:43:27 +00:00
parent 5dda2db9c8
commit 0dc6d4d19c
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=229936
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/libutil/pidfile.c
View File

@ -137,6 +137,20 @@ pidfile_open(const char *path, mode_t mode, pid_t *pidptr)
free(pfh);
return (NULL);
}
/*
* Prevent the file descriptor from escaping to other
* programs via exec(3).
*/
if (fcntl(fd, F_SETFD, FD_CLOEXEC) == -1) {
error = errno;
unlink(pfh->pf_path);
close(fd);
free(pfh);
errno = error;
return (NULL);
}
/*
* Remember file information, so in pidfile_write() we are sure we write
* to the proper descriptor.