From 0e308268b086f55534a7399ab1bea2b6e0d05a2e Mon Sep 17 00:00:00 2001 From: Andrew Turner Date: Tue, 1 Sep 2015 10:47:42 +0000 Subject: [PATCH] Remove an variable we only ever write to, and stop assigning 0 to values in the softc as it's the default value. The latter helps with subclassing this driver. Sponsored by: ABT Systems Ltd --- sys/dev/mmc/host/dwmmc.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/sys/dev/mmc/host/dwmmc.c b/sys/dev/mmc/host/dwmmc.c index 3a4c5f3aa4e2..262ee21fa347 100644 --- a/sys/dev/mmc/host/dwmmc.c +++ b/sys/dev/mmc/host/dwmmc.c @@ -538,7 +538,6 @@ static int dwmmc_attach(device_t dev) { struct dwmmc_softc *sc; - device_t child; int error; int slot; @@ -574,8 +573,6 @@ dwmmc_attach(device_t dev) device_printf(dev, "Hardware version ID is %04x\n", READ4(sc, SDMMC_VERID) & 0xffff); - sc->use_pio = 0; - sc->pwren_inverted = 0; sc->desc_count = DESC_MAX; if ((sc->hwtype & HWTYPE_MASK) == HWTYPE_ROCKCHIP) { @@ -651,7 +648,7 @@ dwmmc_attach(device_t dev) sc->host.host_ocr = MMC_OCR_320_330 | MMC_OCR_330_340; sc->host.caps = MMC_CAP_4_BIT_DATA; - child = device_add_child(dev, "mmc", 0); + device_add_child(dev, "mmc", 0); return (bus_generic_attach(dev)); }