d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

- Check for accf_filter before running the tests, otherwise it will always

Browse Source 
fail at subtest 9/11
- Use strncpy instead of strcpy with afa.af_name
This commit is contained in:
Enji Cooper 2016-01-15 21:59:18 +00:00
parent 9516209bf2
commit 0e47853e87
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=294103
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
tools/regression/sockets/accf_data_attach/accf_data_attach.c
View File

@ -27,6 +27,7 @@
*/
#include <sys/types.h>
#include <sys/module.h>
#include <sys/socket.h>
#include <netinet/in.h>
@ -65,6 +66,16 @@ main(void)
socklen_t len;
int lso, ret;
/* XXX: PLAIN_TEST_REQUIRE_MODULE "backport" for stable/9 */
const char *_mod_name = "accf_data";
if (modfind(_mod_name) == -1) {
printf("1..0 # SKIP - module %s could not be resolved: %s\n",
_mod_name, strerror(errno));
_exit(0);
}
/* XXX: PLAIN_TEST_REQUIRE_MODULE for stable/9 */
printf("1..11\n");
/*
@ -119,7 +130,7 @@ main(void)
* yet a listen() socket.
*/
bzero(&afa, sizeof(afa));
strcpy(afa.af_name, ACCF_NAME);
strncpy(afa.af_name, ACCF_NAME, sizeof(afa.af_name));
ret = setsockopt(lso, SOL_SOCKET, SO_ACCEPTFILTER, &afa, sizeof(afa));
if (ret == 0)
errx(-1, "not ok 5 - setsockopt() before listen() succeeded");
@ -164,7 +175,7 @@ main(void)
* Step 8: After listen(). This call to setsockopt() should succeed.
*/
bzero(&afa, sizeof(afa));
strcpy(afa.af_name, ACCF_NAME);
strncpy(afa.af_name, ACCF_NAME, sizeof(afa.af_name));
ret = setsockopt(lso, SOL_SOCKET, SO_ACCEPTFILTER, &afa, sizeof(afa));
if (ret != 0)
errx(-1, "not ok 9 - setsockopt() after listen() failed with %d "