d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ndis(4): Better mimic the behavior of rand() on Windows.

Browse Source 
In ndis(4) we expose a rand() function that was constantly reseeding
with a time depending function every time it was called. This
essentially broke the reasoning behind seeding, and rendered srand()
a no-op.

Keep it simple, just use random() and srandom() as it's meant to work.
It  would have been tempting to just go for arc4random() but we
want to mimic Microsoft, and we don't need crypto-grade randomness
here.

PR:		209616
MFC after:	2 weeks
This commit is contained in:
Pedro F. Giffuni 2016-05-21 17:38:43 +00:00
parent da6da1575b
commit 0e6d3c6d16
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=300376
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
sys/compat/ndis/subr_ntoskrnl.c
View File

@ -3188,17 +3188,14 @@ atol(str)
static int
rand(void)
{
struct timeval tv;
microtime(&tv);
srandom(tv.tv_usec);
return ((int)random());
return (random());
}
static void
srand(seed)
unsigned int seed;
srand(unsigned int seed)
{
srandom(seed);
}