d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unnecessary dequeue_mutex (added in r294610) from the iWARP

Browse Source 
connection manager.  Examining so_comp without synchronization with
iw_so_event_handler is a harmless race.

Submitted by:	Krishnamraju Eraparaju @ Chelsio
Reviewed by:	Steve Wise @ Open Grid Computing
Sponsored by:	Chelsio Communications
This commit is contained in:
Navdeep Parhar 2016-03-30 01:08:08 +00:00
parent b8e29e065d
commit 0ff41bb737
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=297406
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sys/ofed/drivers/infiniband/core/iwcm.c
View File

@ -79,7 +79,6 @@ struct iwcm_listen_work {
static LIST_HEAD(listen_port_list);
static DEFINE_MUTEX(listen_port_mutex);
static DEFINE_MUTEX(dequeue_mutex);
struct listen_port_info {
struct list_head list;
@ -455,7 +454,6 @@ iw_so_event_handler(struct work_struct *_work)
kfree(work);
return;
}
mutex_lock(&dequeue_mutex);
/* Dequeue & process all new 'so' connection requests for this cmid */
while ((so = dequeue_socket(work->cm_id->so)) != NULL) {
@ -475,7 +473,6 @@ iw_so_event_handler(struct work_struct *_work)
}
}
err:
mutex_unlock(&dequeue_mutex);
kfree(work);
#endif
return;
@ -487,7 +484,6 @@ iw_so_upcall(struct socket *parent_so, void *arg, int waitflag)
struct socket *so;
struct iw_cm_id *cm_id = arg;
mutex_lock(&dequeue_mutex);
/* check whether iw_so_event_handler() already dequeued this 'so' */
so = TAILQ_FIRST(&parent_so->so_comp);
if (!so)
@ -500,7 +496,6 @@ iw_so_upcall(struct socket *parent_so, void *arg, int waitflag)
INIT_WORK(&work->work, iw_so_event_handler);
queue_work(iwcm_wq, &work->work);
mutex_unlock(&dequeue_mutex);
return SU_OK;
}