d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[bwn] Add missing firmware release calls.

Browse Source 
This trips me up whenever I'm fooling around with partially supported
NICs that fail to fully attach or initialise - the firmware gets loaded
and references, but something fails - and the firmware references
aren't cleaned up.
This commit is contained in:
Adrian Chadd 2016-06-05 07:56:28 +00:00
parent 4bfbed7264
commit 14b258b806
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=301435
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sys/dev/bwn/if_bwn.c
View File

@ -750,6 +750,7 @@ bwn_detach(device_t dev)
if (mac->mac_msi != 0)
pci_release_msi(dev);
mbufq_drain(&sc->sc_snd);
bwn_release_firmware(mac);
BWN_LOCK_DESTROY(sc);
return (0);
}
@ -1328,6 +1329,7 @@ bwn_attach_core(struct bwn_mac *mac)
siba_dev_down(sc->sc_dev, 0);
fail:
siba_powerdown(sc->sc_dev);
bwn_release_firmware(mac);
return (error);
}
@ -3930,6 +3932,7 @@ bwn_fw_gets(struct bwn_mac *mac, enum bwn_fwtype type)
}
} else if (rev < 11) {
device_printf(sc->sc_dev, "no PCM for rev %d\n", rev);
bwn_release_firmware(mac);
return (EOPNOTSUPP);
}