From 14fb9485a4dc9c8212bfae6c2049cb4930f4b8e5 Mon Sep 17 00:00:00 2001 From: Emmanuel Vadot Date: Fri, 8 Nov 2019 20:08:44 +0000 Subject: [PATCH] loader.efi: Default to serial if we don't have a ConOut variable In the EFI implementation in U-Boot no ConOut efi variable is created, this cause loader to fallback to TERM_EMU implementation which is very very very slow (and uses the ConOut device in the system table anyway). The UEFI spec aren't clear as if this variable needs to exists or not. Reviewed by: imp, kevans --- stand/efi/loader/main.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/stand/efi/loader/main.c b/stand/efi/loader/main.c index c5d664dce65e..641cc7154f13 100644 --- a/stand/efi/loader/main.c +++ b/stand/efi/loader/main.c @@ -703,8 +703,11 @@ parse_uefi_con_out(void) how = 0; sz = sizeof(buf); rv = efi_global_getenv("ConOut", buf, &sz); - if (rv != EFI_SUCCESS) + if (rv != EFI_SUCCESS) { + /* If we don't have any ConOut default to serial */ + how = RB_SERIAL; goto out; + } ep = buf + sz; node = (EFI_DEVICE_PATH *)buf; while ((char *)node < ep) {