d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

When the source and destination objects for VOP_RENAME() are the same,

Browse Source 
POSIX advice to just ignore the operation and return 0.
We already handle this case in kern_rename(), but don't give bad example -
the source is not removed.
This commit is contained in:
Pawel Jakub Dawidek 2006-11-04 23:59:51 +00:00
parent 479a8f8dd7
commit 162ce1a75f
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=163990
1 changed files with 6 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
share/man/man9/VOP_RENAME.9
View File

@ -104,34 +104,13 @@ vop_rename(struct vnode *fdvp, struct vnode *fvp, struct componentname *fcnp,
}
/*
* Check if just deleting a link name.
* POSIX: "If the old argument and the new argument
* both refer to links to the same existing file,
* the rename() function shall return successfully
* and perform no other action."
* The upper layers already handle this case.
*/
if (fvp == tvp) {
if (fvp->v_type == VDIR) {
error = EINVAL;
goto abortit;
}
/*
* Release destination.
*/
vput(tdvp);
vput(tvp);
/*
* Delete source. Pretty bizarre stuff.
*/
vrele(fdvp);
vrele(fvp);
fcnp->cn_flags &= ~MODMASK;
fcnp->cn_flags |= LOCKPARENT | LOCKLEAF;
fcnp->cn_nameiop = DELETE;
VREF(fdvp);
error = relookup(fdvp, &fvp, fcnp);
if (error == 0)
vrele(fdvp);
return VOP_REMOVE(fdvp, fvp, fcnp);
}
KASSERT(fvp != tvp, ("vop_rename: source and destination are the same"));
if (fvp is immutable) {
error = EPERM;