sysctl_kern_proc_args: do not take the fast path if p_args is NULL

In this case it falls back to reading ps_strings
This commit is contained in:
Antoine Brodin 2018-01-01 21:25:01 +00:00
parent 84874cc151
commit 1b25176cbc
Notes: svn2git 2020-12-20 02:59:44 +00:00
svn path=/head/; revision=327473

View File

@ -1920,11 +1920,9 @@ sysctl_kern_proc_args(SYSCTL_HANDLER_ARGS)
* is nobody to modify pargs, thus we can just read.
*/
p = curproc;
if (pid == p->p_pid && p->p_numthreads == 1 && req->newptr == NULL) {
if ((pa = p->p_args) != NULL)
error = SYSCTL_OUT(req, pa->ar_args, pa->ar_length);
return (error);
}
if (pid == p->p_pid && p->p_numthreads == 1 && req->newptr == NULL &&
(pa = p->p_args) != NULL)
return (SYSCTL_OUT(req, pa->ar_args, pa->ar_length));
flags = PGET_CANSEE;
if (req->newptr != NULL)