pf tests: fix up a couple WARNS= 6 nits
common_init_tbl is only used within this single CU, so it should be marked static. WARNS=6 also complained about the var defined by `ATF_TC_WITH_CLEANUP(getastats);` being unused, which turns out to be because it's not been hooked up in ATF_TP_ADD_TCS. kp@ did not immediately recall any reason for this, and the case passes on my local system, so hook it up. Note that I've not yet set WARNS= 6 here. Investigation is underway to see if we can feasibly default WARNS to 6 for src builds to catch directories too deep to inherit a WARNS from the top-level subdirectories' Makefile.inc. Those particular WARNS settings will be subsequently removed as they become redundant with a more-global default. MFC after: 1 week
This commit is contained in:
parent
ec048c7550
commit
1d2e31af14
Notes:
svn2git
2020-12-20 02:59:44 +00:00
svn path=/head/; revision=361065
@ -51,7 +51,7 @@ static int dev;
|
||||
#define COMMON_CLEANUP() \
|
||||
close(dev);
|
||||
|
||||
void
|
||||
static void
|
||||
common_init_tbl(struct pfr_table *tbl)
|
||||
{
|
||||
bzero(tbl, sizeof(struct pfr_table));
|
||||
@ -795,6 +795,7 @@ ATF_TP_ADD_TCS(tp)
|
||||
ATF_TP_ADD_TC(tp, addtables);
|
||||
ATF_TP_ADD_TC(tp, deltables);
|
||||
ATF_TP_ADD_TC(tp, gettables);
|
||||
ATF_TP_ADD_TC(tp, getastats);
|
||||
ATF_TP_ADD_TC(tp, gettstats);
|
||||
ATF_TP_ADD_TC(tp, clrtstats);
|
||||
ATF_TP_ADD_TC(tp, settflags);
|
||||
|
Loading…
Reference in New Issue
Block a user