d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pf tests: fix up a couple WARNS= 6 nits

Browse Source 
common_init_tbl is only used within this single CU, so it should be marked
static.

WARNS=6 also complained about the var defined by
`ATF_TC_WITH_CLEANUP(getastats);` being unused, which turns out to be
because it's not been hooked up in ATF_TP_ADD_TCS. kp@ did not immediately
recall any reason for this, and the case passes on my local system, so hook
it up.

Note that I've not yet set WARNS= 6 here. Investigation is underway to see
if we can feasibly default WARNS to 6 for src builds to catch directories
too deep to inherit a WARNS from the top-level subdirectories' Makefile.inc.
Those particular WARNS settings will be subsequently removed as they become
redundant with a more-global default.

MFC after:	1 week
This commit is contained in:
Kyle Evans 2020-05-14 23:20:58 +00:00
parent ec048c7550
commit 1d2e31af14
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=361065
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tests/sys/netpfil/pf/ioctl/validation.c
View File

@ -51,7 +51,7 @@ static int dev;
#define COMMON_CLEANUP() \
close(dev);
void
static void
common_init_tbl(struct pfr_table *tbl)
{
bzero(tbl, sizeof(struct pfr_table));
@ -795,6 +795,7 @@ ATF_TP_ADD_TCS(tp)
ATF_TP_ADD_TC(tp, addtables);
ATF_TP_ADD_TC(tp, deltables);
ATF_TP_ADD_TC(tp, gettables);
ATF_TP_ADD_TC(tp, getastats);
ATF_TP_ADD_TC(tp, gettstats);
ATF_TP_ADD_TC(tp, clrtstats);
ATF_TP_ADD_TC(tp, settflags);