d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

The 'while (array != NULL) { }' suggests scan-build that array may be

Browse Source 
initially NULL, which is not possible. Change the loop to
'do {} while (array != NULL)' to satisfy scan-build and assert that
array really cannot be NULL just in case.

Submitted by:	pjd@
Found by:	scan-build
MFC after:	1 month
Sponsored by:	Wheel Systems
This commit is contained in:
Mariusz Zaborski 2017-09-21 10:03:14 +00:00
parent 08016b3185
commit 1dacabe1ab
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=323852
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sys/contrib/libnv/nvlist.c
View File

@ -1200,12 +1200,13 @@ nvlist_xunpack(const void *buf, size_t size, const int *fds, size_t nfds,
&array);
if (ptr == NULL)
goto failed;
PJDLOG_ASSERT(array != NULL);
tmpnvl = array;
while (array != NULL) {
do {
nvlist_set_parent(array, nvp);
array = __DECONST(nvlist_t *,
nvlist_get_array_next(array));
}
} while (array != NULL);
ptr = nvlist_unpack_header(tmpnvl, ptr, nfds, &isbe,
&left);
break;