d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't use PTY name as format string, even though it isn't insecure here.

Browse Source 
It's guaranteed that the `name' variable always contains a string of the
form pty[l‐sL‐S][0‐9a‐v], but I'd rather keep the compiler happy (LLVM).
This commit is contained in:
Ed Schouten 2009-02-26 10:14:10 +00:00
parent 98621d508c
commit 1e737f33a0
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=189060
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sys/kern/tty_pty.c
View File

@ -113,7 +113,7 @@ pty_clone(void *arg, struct ucred *cr, char *name, int namelen,
/* Create the controller device node. */
*dev = make_dev_credf(MAKEDEV_REF, &ptydev_cdevsw, 0,
NULL, UID_ROOT, GID_WHEEL, 0666, name);
NULL, UID_ROOT, GID_WHEEL, 0666, "%s", name);
}
static void