d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

When NFS was converted to the new mount syscall, code was written that sets

Browse Source 
the MNT_RDONLY flag if the "ro" option was passed in from userland, and
clears it otherwise.  In the diskless case, the MNT_RDONLY flag is already
set when this code is reached, but there are no mount options, so it was
incorrectly cleared.  Change the logic so the MNT_RDONLY flag is set if the
"ro" option was specified, and left alone otherwise.

Note that the NFS code will still happily let you mount a filesystem RW
even if the server exports it RO.  I'm not sure how to fix that.
This commit is contained in:
des 2005-04-27 14:46:02 +00:00
parent ee7aa06495
commit 216351ffe6
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/nfsclient/nfs_vfsops.c
View File

@ -513,9 +513,7 @@ nfs_decode_args(struct mount *mp, struct nfsmount *nmp, struct nfs_args *argp)
int maxio; int maxio;
s = splnet(); s = splnet();
if (vfs_getopt(mp->mnt_optnew, "ro", NULL, NULL)) if (vfs_getopt(mp->mnt_optnew, "ro", NULL, NULL) == 0)
mp->mnt_flag &= ~MNT_RDONLY;
else
mp->mnt_flag |= MNT_RDONLY; mp->mnt_flag |= MNT_RDONLY;
/* /*
* Silently clear NFSMNT_NOCONN if it's a TCP mount, it makes * Silently clear NFSMNT_NOCONN if it's a TCP mount, it makes