From 21d0712c338bea484628677d29189e777fdf4391 Mon Sep 17 00:00:00 2001 From: Alexander Motin Date: Wed, 16 Oct 2013 09:21:40 +0000 Subject: [PATCH] MFprojects/camlock r256371: Fix passing uninitialized bio_resid argument to g_trace(). --- sys/geom/geom_dev.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sys/geom/geom_dev.c b/sys/geom/geom_dev.c index 17f24f8dcb27..0b4ffbf8017f 100644 --- a/sys/geom/geom_dev.c +++ b/sys/geom/geom_dev.c @@ -485,16 +485,16 @@ g_dev_done(struct bio *bp2) sc = cp->private; bp = bp2->bio_parent; bp->bio_error = bp2->bio_error; - if (bp->bio_error != 0) { + bp->bio_completed = bp2->bio_completed; + bp->bio_resid = bp2->bio_resid; + if (bp2->bio_error != 0) { g_trace(G_T_BIO, "g_dev_done(%p) had error %d", - bp2, bp->bio_error); + bp2, bp2->bio_error); bp->bio_flags |= BIO_ERROR; } else { g_trace(G_T_BIO, "g_dev_done(%p/%p) resid %ld completed %jd", - bp2, bp, bp->bio_resid, (intmax_t)bp2->bio_completed); + bp2, bp, bp2->bio_resid, (intmax_t)bp2->bio_completed); } - bp->bio_resid = bp->bio_length - bp2->bio_completed; - bp->bio_completed = bp2->bio_completed; g_destroy_bio(bp2); destroy = 0; mtx_lock(&sc->sc_mtx);