Don't consider PCIe hot-plug command timeout fatal.
According to my tests and errata to several generations of Intel CPUs, PCIe hot-plug command completion reporting is not very reliable thing. At least on my Supermicro X11DPi-NT board I never saw it reported. Before this change timeout code detached devices and tried to disable the slot, that in my case resulted in hot-plugged device being detached just a second after it was successfully detected and attached. This change removes that, so in case of timeout it just prints the error and continue operation. Linux does the same. MFC after: 1 week Sponsored by: iXsystems, Inc.
This commit is contained in:
parent
87210a0c6d
commit
21e51c82fb
Notes:
svn2git
2020-12-20 02:59:44 +00:00
svn path=/head/; revision=351514
@ -1272,11 +1272,8 @@ pcib_pcie_cc_timeout(void *arg)
|
||||
mtx_assert(&Giant, MA_OWNED);
|
||||
sta = pcie_read_config(dev, PCIER_SLOT_STA, 2);
|
||||
if (!(sta & PCIEM_SLOT_STA_CC)) {
|
||||
device_printf(dev,
|
||||
"HotPlug Command Timed Out - forcing detach\n");
|
||||
sc->flags &= ~(PCIB_HOTPLUG_CMD_PENDING | PCIB_DETACH_PENDING);
|
||||
sc->flags |= PCIB_DETACHING;
|
||||
pcib_pcie_hotplug_update(sc, 0, 0, true);
|
||||
device_printf(dev, "HotPlug Command Timed Out\n");
|
||||
sc->flags &= ~PCIB_HOTPLUG_CMD_PENDING;
|
||||
} else {
|
||||
device_printf(dev,
|
||||
"Missed HotPlug interrupt waiting for Command Completion\n");
|
||||
|
Loading…
Reference in New Issue
Block a user