From 21e7bc5e52729ead42a2f5a7ed0eacdc23afd546 Mon Sep 17 00:00:00 2001 From: Pawel Jakub Dawidek Date: Thu, 3 Feb 2011 11:33:32 +0000 Subject: [PATCH] Add missing locking after moving keepalive_send() to remote send thread in r214692. MFC after: 1 week --- sbin/hastd/primary.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/sbin/hastd/primary.c b/sbin/hastd/primary.c index 656ead955c5c..708109625feb 100644 --- a/sbin/hastd/primary.c +++ b/sbin/hastd/primary.c @@ -1230,8 +1230,12 @@ keepalive_send(struct hast_resource *res, unsigned int ncomp) { struct nv *nv; - if (!ISCONNECTED(res, ncomp)) + rw_rlock(&hio_remote_lock[ncomp]); + + if (!ISCONNECTED(res, ncomp)) { + rw_unlock(&hio_remote_lock[ncomp]); return; + } PJDLOG_ASSERT(res->hr_remotein != NULL); PJDLOG_ASSERT(res->hr_remoteout != NULL); @@ -1239,20 +1243,22 @@ keepalive_send(struct hast_resource *res, unsigned int ncomp) nv = nv_alloc(); nv_add_uint8(nv, HIO_KEEPALIVE, "cmd"); if (nv_error(nv) != 0) { + rw_unlock(&hio_remote_lock[ncomp]); nv_free(nv); pjdlog_debug(1, "keepalive_send: Unable to prepare header to send."); return; } if (hast_proto_send(res, res->hr_remoteout, nv, NULL, 0) < 0) { + rw_unlock(&hio_remote_lock[ncomp]); pjdlog_common(LOG_DEBUG, 1, errno, "keepalive_send: Unable to send request"); nv_free(nv); - rw_unlock(&hio_remote_lock[ncomp]); remote_close(res, ncomp); - rw_rlock(&hio_remote_lock[ncomp]); return; } + + rw_unlock(&hio_remote_lock[ncomp]); nv_free(nv); pjdlog_debug(2, "keepalive_send: Request sent."); }