d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add check for failure of mkstemp and setenv.

Browse Source 
Reviewed by:	des
Approved by:	cperciva (implicit)
Obtained from:	DragonFlyBSD
MFC after:	1 week
This commit is contained in:
Eitan Adler 2012-12-08 18:41:16 +00:00
parent 689f0bd93b
commit 2214137ab1
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=244037
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
usr.bin/fetch/fetch.c
View File

@ -618,7 +618,10 @@ fetch(char *URL, const char *path)
asprintf(&tmppath, "%.*s.fetch.XXXXXX.%s",
(int)(slash - path), path, slash);
if (tmppath != NULL) {
mkstemps(tmppath, strlen(slash) + 1);
if (mkstemps(tmppath, strlen(slash) + 1) == -1) {
warn("%s: mkstemps()", path);
goto failure;
}
of = fopen(tmppath, "w");
chown(tmppath, sb.st_uid, sb.st_gid);
chmod(tmppath, sb.st_mode & ALLPERMS);
@ -988,7 +991,8 @@ main(int argc, char *argv[])
if (v_tty)
fetchAuthMethod = query_auth;
if (N_filename != NULL)
setenv("NETRC", N_filename, 1);
if (setenv("NETRC", N_filename, 1) == -1)
err(1, "setenv: cannot set NETRC=%s", N_filename);
while (argc) {
if ((p = strrchr(*argv, '/')) == NULL)