MFV 331702:
9187 racing condition between vdev label and spa_last_synced_txg in vdev_validate illumos/illumos-gate@d1de72cfa2 ztest failed with uncorrectable IO error despite having the fix for #7163. Both sides of the mirror have CANT_OPEN_BAD_LABEL, which also distinguishes it from that issue. Definitely seems like a racing condition between the vdev_validate and spa_sync: 1. Thread A (spa_sync): vdev label is updated to latest txg 2. Thread B (vdev_validate): vdev label's txg is compared to spa_last_synced_txg and is ahead. 3. Thread A (spa_sync): spa_last_synced_txg is updated to latest txg. Solution: do not check txg in vdev_validate unless config lock is held. Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Matt Ahrens <matthew.ahrens@delphix.com> Approved by: Robert Mustacchi <rm@joyent.com> Author: Pavel Zakharov <pavel.zakharov@delphix.com>
This commit is contained in:
commit
2221f0d8af
Notes:
svn2git
2020-12-20 02:59:44 +00:00
svn path=/head/; revision=331703
@ -1696,8 +1696,11 @@ vdev_validate(vdev_t *vd)
|
||||
/*
|
||||
* If we are performing an extreme rewind, we allow for a label that
|
||||
* was modified at a point after the current txg.
|
||||
* If config lock is not held do not check for the txg. spa_sync could
|
||||
* be updating the vdev's label before updating spa_last_synced_txg.
|
||||
*/
|
||||
if (spa->spa_extreme_rewind || spa_last_synced_txg(spa) == 0)
|
||||
if (spa->spa_extreme_rewind || spa_last_synced_txg(spa) == 0 ||
|
||||
spa_config_held(spa, SCL_CONFIG, RW_WRITER) != SCL_CONFIG)
|
||||
txg = UINT64_MAX;
|
||||
else
|
||||
txg = spa_last_synced_txg(spa);
|
||||
|
Loading…
Reference in New Issue
Block a user