d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't cap FirstBurstLength to maximum MaxRecvDataSegmentLength claimed

Browse Source 
by the offload driver; there is no reason to do so, and it actually
harms performance.

MFC after:	1 month
This commit is contained in:
Edward Tomasz Napierala 2016-06-09 07:19:02 +00:00
parent 16e3675494
commit 2317fdfa8c
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=301720
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
usr.sbin/ctld/ctld.h
View File

@ -49,6 +49,7 @@
#define MAX_NAME_LEN 223
#define MAX_DATA_SEGMENT_LENGTH (128 * 1024)
#define MAX_BURST_LENGTH 16776192
#define FIRST_BURST_LENGTH (128 * 1024)
#define SOCKBUF_SIZE 1048576
struct auth {

11
usr.sbin/ctld/login.c
View File

@ -574,13 +574,12 @@ login_negotiate_key(struct pdu *request, const char *name,
tmp = strtoul(value, NULL, 10);
if (tmp <= 0) {
login_send_error(request, 0x02, 0x00);
log_errx(1, "received invalid "
"FirstBurstLength");
log_errx(1, "received invalid FirstBurstLength");
}
if (tmp > conn->conn_data_segment_limit) {
log_debugx("capping FirstBurstLength from %zd to %zd",
tmp, conn->conn_data_segment_limit);
tmp = conn->conn_data_segment_limit;
if (tmp > FIRST_BURST_LENGTH) {
log_debugx("capping FirstBurstLength from %zd to %d",
tmp, FIRST_BURST_LENGTH);
tmp = FIRST_BURST_LENGTH;
}
conn->conn_first_burst_length = tmp;
keys_add_int(response_keys, name, tmp);