d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pf tests: Try to provoke the panic with invalid DIOCRSETTFLAGS

Browse Source 
There was an issue with copyin() on DIOCRSETTFLAGS, which would panic if
pfrio_buffer was NULL.
Test for the issue fixed in r346319.

MFC after:	1 week
Event:		Aberdeen hackathon 2019
This commit is contained in:
Kristof Provost 2019-04-17 16:45:35 +00:00
parent f5e0d9fcb4
commit 246e18b224
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=346320
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tests/sys/netpfil/pf/ioctl/validation.c
View File

@ -305,6 +305,11 @@ ATF_TC_BODY(settflags, tc)
io.pfrio_size = 1 << 28;
if (ioctl(dev, DIOCRSETTFLAGS, &io) != 0)
atf_tc_fail("Request with size 1 << 24 failed");
/* NULL buffer */
io.pfrio_buffer = NULL;
if (ioctl(dev, DIOCRSETTFLAGS, &io) != -1)
atf_tc_fail("Request with NULL buffer succeeded");
}
ATF_TC_CLEANUP(settflags, tc)