d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add an extra (void *) cast. The struct if_msghdr has an 8 byte

Browse Source 
alignment requirement, while rt_msghdr has a 4 byte alignment
requirement.  The root cause is that if_msghdr has an struct if_data
which has an 8-byte alignment requirement due to a time_t that's
embedded in it.  On MIPS, time_t is a 64-bit number, so must be 64-bit
aligned.

Since we don't access ifm_data.ifi_epoch, a simple cast is all that's
necessary here.  It is likely the case that ifi_epoch should *NOT* be
a time_t because it is an uptime (time delta) an not an absolute time
since 1970.  u_long is likely sufficient there since that gives an
uptime of 136 years will suffice for the foreseeable future.
This commit is contained in:
Warner Losh 2009-02-18 19:59:27 +00:00
parent 217dc6b01c
commit 26ea346865
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=188760
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
contrib/bsnmp/snmp_mibII/mibII.c
View File

@ -1013,7 +1013,7 @@ handle_rtmsg(struct rt_msghdr *rtm)
break;
case RTM_IFINFO:
ifm = (struct if_msghdr *)rtm;
ifm = (struct if_msghdr *)(void *)rtm;
mib_extract_addrs(ifm->ifm_addrs, (u_char *)(ifm + 1), addrs);
if ((ifp = mib_find_if_sys(ifm->ifm_index)) == NULL)
break;