d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

xen/intr: do full xenisrc initialization during binding

Browse Source 
Keeping released xenisrcs in a known state simplifies allocation, but
forces the allocation function to maintain that state.  This turns into
a problem when trying to allow for interchangeable allocation functions.
Fix this issue by ensuring xenisrcs are always *fully* initialized
during binding.

Reviewed by: royger
This commit is contained in:
Elliott Mitchell 2021-05-13 21:36:02 -07:00 committed by Roger Pau Monné
parent ff73b1d69b
commit 2794893ebf
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
sys/x86/xen/xen_intr.c
View File

@ -406,10 +406,6 @@ xen_intr_release_isrc(struct xenisrc *isrc)
/* not reachable from xen_intr_port_to_isrc[], unlock */
mtx_unlock(&xen_intr_isrc_lock);
isrc->xi_cpu = 0;
isrc->xi_port = INVALID_EVTCHN;
isrc->xi_cookie = NULL;
mtx_lock(&xen_intr_x86_lock);
isrc->xi_type = EVTCHN_TYPE_UNBOUND;
mtx_unlock(&xen_intr_x86_lock);
@ -456,8 +452,11 @@ xen_intr_bind_isrc(struct xenisrc **isrcp, evtchn_port_t local_port,
isrc = xen_intr_alloc_isrc(type);
if (isrc == NULL)
return (ENOSPC);
isrc->xi_cookie = NULL;
isrc->xi_port = local_port;
isrc->xi_close = false;
isrc->xi_cpu = 0;
refcount_init(&isrc->xi_refcount, 1);
mtx_lock(&xen_intr_isrc_lock);
xen_intr_port_to_isrc[isrc->xi_port] = isrc;