d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use 4-byte padding for core dump notes on both 32 and 64bit archs.

Browse Source 
Although native word padding (i.e. 8-byte on 64bit arch) looks to be
in agreement with standards, other parts of our code and other OSes
use 4-byte alignment.

This is not expected to change alignment for currently generated core
dump notes, as the notes look to consist of structures with sizes
multiple of 8 on 64-bit archs. But there are plans to add additional
notes, where 4-byte vs 8-byte alignment makes difference.

Discussed with:	kib
Reviewed by:	kib
MFC after:	2 weeks
This commit is contained in:
Mikolaj Golub 2013-04-07 17:40:49 +00:00
parent 7d919c164d
commit 27b056480e
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=249238
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/kern/imgact_elf.c
View File

@ -1538,10 +1538,10 @@ __elfN(putnote)(void *dst, size_t *off, const char *name, int type,
*off += sizeof note;
if (dst != NULL)
bcopy(name, (char *)dst + *off, note.n_namesz);
*off += roundup2(note.n_namesz, sizeof(Elf_Size));
*off += roundup2(note.n_namesz, sizeof(Elf32_Size));
if (dst != NULL)
bcopy(desc, (char *)dst + *off, note.n_descsz);
*off += roundup2(note.n_descsz, sizeof(Elf_Size));
*off += roundup2(note.n_descsz, sizeof(Elf32_Size));
}
static boolean_t