d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ip_reass: optimize ipreass_drain_vnet()

Browse Source 
- Call ipreass_reschedule() only once per slot [1]
- Aggregate stats and update them once

Suggested by:	jtl [1]
This commit is contained in:
Gleb Smirnoff 2022-09-10 02:11:39 -07:00
parent 13018bfae8
commit 29b4b63c59
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
sys/netinet/ip_reass.c
View File

@ -633,16 +633,27 @@ ipreass_reschedule(struct ipqbucket *bucket)
static void
ipreass_drain_vnet(void)
{
u_int dropped = 0;
for (int i = 0; i < V_ipq_hashsize; i++) {
bool resched;
IPQ_LOCK(i);
while(!TAILQ_EMPTY(&V_ipq[i].head))
ipq_drop(&V_ipq[i], TAILQ_FIRST(&V_ipq[i].head));
resched = !TAILQ_EMPTY(&V_ipq[i].head);
while(!TAILQ_EMPTY(&V_ipq[i].head)) {
struct ipq *fp = TAILQ_FIRST(&V_ipq[i].head);
dropped += fp->ipq_nfrags;
ipq_free(&V_ipq[i], fp);
}
if (resched)
ipreass_reschedule(&V_ipq[i]);
KASSERT(V_ipq[i].count == 0,
("%s: V_ipq[%d] count %d (V_ipq=%p)", __func__, i,
V_ipq[i].count, V_ipq));
IPQ_UNLOCK(i);
}
IPSTAT_ADD(ips_fragdropped, dropped);
}
/*