From 2b7432629c29fce9ac1d91c1e52465a82043ae39 Mon Sep 17 00:00:00 2001 From: Alexander Kabaev Date: Sat, 28 Feb 2015 20:30:29 +0000 Subject: [PATCH] Avoid closing unallocated socket in case socreate fails. Found by: Brainy Code Scanner Reported by: Maxime Villard MFC after: 2 weeks --- sys/nfs/krpc_subr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/nfs/krpc_subr.c b/sys/nfs/krpc_subr.c index ae51aceda49c..2d37c10896fb 100644 --- a/sys/nfs/krpc_subr.c +++ b/sys/nfs/krpc_subr.c @@ -220,7 +220,7 @@ krpc_call(struct sockaddr_in *sa, u_int prog, u_int vers, u_int func, * Create socket and set its recieve timeout. */ if ((error = socreate(AF_INET, &so, SOCK_DGRAM, 0, td->td_ucred, td))) - goto out; + return error; tv.tv_sec = 1; tv.tv_usec = 0;