d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PR#259071 provides a test program that fails for the NFS client.

Browse Source 
Testing with it, there appears to be a race between Lookup
and VOPs like Setattr-of-size, where Lookup ends up loading
stale attributes (including what might be the wrong file size)
into the NFS vnode's attribute cache.

The race occurs when the modifying VOP (which holds a lock
on the vnode), blocks the acquisition of the vnode in Lookup,
after the RPC (with now potentially stale attributes).

Here's what seems to happen:
Child                                Parent

does stat(), which does
VOP_LOOKUP(), doing the Lookup
RPC with the directory vnode
locked, acquiring file attributes
valid at this point in time

blocks waiting for locked file       does ftruncate(), which
vnode                                does VOP_SETATTR() of Size,
                                     changing the file's size
                                     while holding an exclusive
                                     lock on the file's vnode
                                     releases the vnode lock
acquires file vnode and fills in
now stale attributes including
the old wrong Size
                                     does a read() which returns
                                     wrong data size

This patch fixes the problem by saving a timestamp in the NFS vnode
in the VOPs that modify the file (Setattr-of-size, Allocate).
Then lookup/readdirplus compares that timestamp with the time just
before starting the RPC after it has acquired the file's vnode.
If the modifying RPC occurred during the Lookup, the attributes
in the RPC reply are discarded, since they might be stale.

With this patch the test program works as expected.

Note that the test program does not fail on a July stable/12,
although this race is in the NFS client code.  I suspect a
fairly recent change to the name caching code exposed this
bug.

PR:	259071
Reviewed by:	asomers
MFC after:	2 weeks
Differential Revision:	https://reviews.freebsd.org/D32635
This commit is contained in:
Rick Macklem 2021-10-30 16:35:02 -07:00
parent f0d9a6a781
commit 2be417843a
3 changed files with 99 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
sys/fs/nfsclient/nfs_clrpcops.c
View File

@ -3630,7 +3630,8 @@ nfsrpc_readdirplus(vnode_t vp, struct uio *uiop, nfsuint64 *cookiep,
nfsattrbit_t attrbits, dattrbits;
size_t tresid;
u_int32_t *tl2 = NULL, rderr;
struct timespec dctime;
struct timespec dctime, ts;
bool attr_ok;
KASSERT(uiop->uio_iovcnt == 1 &&
(uiop->uio_resid & (DIRBLKSIZ - 1)) == 0,
@ -3815,6 +3816,7 @@ nfsrpc_readdirplus(vnode_t vp, struct uio *uiop, nfsuint64 *cookiep,
*tl = txdr_unsigned(NFSV4OP_GETATTR);
(void) nfsrv_putattrbit(nd, &dattrbits);
}
nanouptime(&ts);
error = nfscl_request(nd, vp, p, cred, stuff);
if (error)
return (error);
@ -3972,6 +3974,7 @@ nfsrpc_readdirplus(vnode_t vp, struct uio *uiop, nfsuint64 *cookiep,
ncookie.lval[1];
if (nfhp != NULL) {
attr_ok = true;
if (NFSRV_CMPFH(nfhp->nfh_fh, nfhp->nfh_len,
dnp->n_fhp->nfh_fh, dnp->n_fhp->nfh_len)) {
VREF(vp);
@ -4001,12 +4004,32 @@ nfsrpc_readdirplus(vnode_t vp, struct uio *uiop, nfsuint64 *cookiep,
if (!error) {
newvp = NFSTOV(np);
unlocknewvp = 1;
/*
* If n_localmodtime >= time before RPC,
* then a file modification operation,
* such as VOP_SETATTR() of size, has
* occurred while the Lookup RPC and
* acquisition of the vnode happened. As
* such, the attributes might be stale,
* with possibly an incorrect size.
*/
NFSLOCKNODE(np);
if (timespecisset(
&np->n_localmodtime) &&
timespeccmp(&np->n_localmodtime,
&ts, >=)) {
NFSCL_DEBUG(4, "nfsrpc_readdirplus:"
" localmod stale attributes\n");
attr_ok = false;
}
NFSUNLOCKNODE(np);
}
}
nfhp = NULL;
if (newvp != NULLVP) {
error = nfscl_loadattrcache(&newvp,
&nfsva, NULL, NULL, 0, 0);
if (attr_ok)
error = nfscl_loadattrcache(&newvp,
&nfsva, NULL, NULL, 0, 0);
if (error) {
if (unlocknewvp)
vput(newvp);

78
sys/fs/nfsclient/nfs_clvnops.c
View File

@ -1014,6 +1014,7 @@ nfs_setattr(struct vop_setattr_args *ap)
struct vattr *vap = ap->a_vap;
int error = 0;
u_quad_t tsize;
struct timespec ts;
#ifndef nolint
tsize = (u_quad_t)0;
@ -1108,11 +1109,18 @@ nfs_setattr(struct vop_setattr_args *ap)
NFSUNLOCKNODE(np);
}
error = nfs_setattrrpc(vp, vap, ap->a_cred, td);
if (error && vap->va_size != VNOVAL) {
NFSLOCKNODE(np);
np->n_size = np->n_vattr.na_size = tsize;
vnode_pager_setsize(vp, tsize);
NFSUNLOCKNODE(np);
if (vap->va_size != VNOVAL) {
if (error == 0) {
nanouptime(&ts);
NFSLOCKNODE(np);
np->n_localmodtime = ts;
NFSUNLOCKNODE(np);
} else {
NFSLOCKNODE(np);
np->n_size = np->n_vattr.na_size = tsize;
vnode_pager_setsize(vp, tsize);
NFSUNLOCKNODE(np);
}
}
return (error);
}
@ -1169,7 +1177,7 @@ nfs_lookup(struct vop_lookup_args *ap)
struct nfsfh *nfhp;
struct nfsvattr dnfsva, nfsva;
struct vattr vattr;
struct timespec nctime;
struct timespec nctime, ts;
uint32_t openmode;
*vpp = NULLVP;
@ -1293,6 +1301,7 @@ nfs_lookup(struct vop_lookup_args *ap)
newvp = NULLVP;
NFSINCRGLOBAL(nfsstatsv1.lookupcache_misses);
nanouptime(&ts);
error = nfsrpc_lookup(dvp, cnp->cn_nameptr, cnp->cn_namelen,
cnp->cn_cred, td, &dnfsva, &nfsva, &nfhp, &attrflag, &dattrflag,
NULL, openmode);
@ -1359,6 +1368,22 @@ nfs_lookup(struct vop_lookup_args *ap)
if (error)
return (error);
newvp = NFSTOV(np);
/*
* If n_localmodtime >= time before RPC, then
* a file modification operation, such as
* VOP_SETATTR() of size, has occurred while
* the Lookup RPC and acquisition of the vnode
* happened. As such, the attributes might
* be stale, with possibly an incorrect size.
*/
NFSLOCKNODE(np);
if (timespecisset(&np->n_localmodtime) &&
timespeccmp(&np->n_localmodtime, &ts, >=)) {
NFSCL_DEBUG(4, "nfs_lookup: rename localmod "
"stale attributes\n");
attrflag = 0;
}
NFSUNLOCKNODE(np);
if (attrflag)
(void) nfscl_loadattrcache(&newvp, &nfsva, NULL, NULL,
0, 1);
@ -1418,6 +1443,22 @@ nfs_lookup(struct vop_lookup_args *ap)
if (error)
return (error);
newvp = NFSTOV(np);
/*
* If n_localmodtime >= time before RPC, then
* a file modification operation, such as
* VOP_SETATTR() of size, has occurred while
* the Lookup RPC and acquisition of the vnode
* happened. As such, the attributes might
* be stale, with possibly an incorrect size.
*/
NFSLOCKNODE(np);
if (timespecisset(&np->n_localmodtime) &&
timespeccmp(&np->n_localmodtime, &ts, >=)) {
NFSCL_DEBUG(4, "nfs_lookup: localmod "
"stale attributes\n");
attrflag = 0;
}
NFSUNLOCKNODE(np);
if (attrflag)
(void) nfscl_loadattrcache(&newvp, &nfsva, NULL, NULL,
0, 1);
@ -2635,7 +2676,9 @@ nfs_lookitup(struct vnode *dvp, char *name, int len, struct ucred *cred,
struct componentname cn;
int error = 0, attrflag, dattrflag;
u_int hash;
struct timespec ts;
nanouptime(&ts);
error = nfsrpc_lookup(dvp, name, len, cred, td, &dnfsva, &nfsva,
&nfhp, &attrflag, &dattrflag, NULL, 0);
if (dattrflag)
@ -2696,6 +2739,22 @@ printf("replace=%s\n",nnn);
if (error)
return (error);
newvp = NFSTOV(np);
/*
* If n_localmodtime >= time before RPC, then
* a file modification operation, such as
* VOP_SETATTR() of size, has occurred while
* the Lookup RPC and acquisition of the vnode
* happened. As such, the attributes might
* be stale, with possibly an incorrect size.
*/
NFSLOCKNODE(np);
if (timespecisset(&np->n_localmodtime) &&
timespeccmp(&np->n_localmodtime, &ts, >=)) {
NFSCL_DEBUG(4, "nfs_lookitup: localmod "
"stale attributes\n");
attrflag = 0;
}
NFSUNLOCKNODE(np);
}
if (!attrflag && *npp == NULL) {
if (newvp == dvp)
@ -3643,11 +3702,14 @@ nfs_allocate(struct vop_allocate_args *ap)
struct thread *td = curthread;
struct nfsvattr nfsva;
struct nfsmount *nmp;
struct nfsnode *np;
off_t alen;
int attrflag, error, ret;
struct timespec ts;
attrflag = 0;
nmp = VFSTONFS(vp->v_mount);
np = VTONFS(vp);
mtx_lock(&nmp->nm_mtx);
if (NFSHASNFSV4(nmp) && nmp->nm_minorvers >= NFSV42_MINORVERSION &&
(nmp->nm_privflag & NFSMNTP_NOALLOCATE) == 0) {
@ -3667,6 +3729,10 @@ nfs_allocate(struct vop_allocate_args *ap)
if (error == 0) {
*ap->a_offset += alen;
*ap->a_len -= alen;
nanouptime(&ts);
NFSLOCKNODE(np);
np->n_localmodtime = ts;
NFSUNLOCKNODE(np);
} else if (error == NFSERR_NOTSUPP) {
mtx_lock(&nmp->nm_mtx);
nmp->nm_privflag |= NFSMNTP_NOALLOCATE;

1
sys/fs/nfsclient/nfsnode.h
View File

@ -129,6 +129,7 @@ struct nfsnode {
struct nfsv4node *n_v4; /* extra V4 stuff */
struct ucred *n_writecred; /* Cred. for putpages */
struct nfsclopen *n_openstateid; /* Cached open stateid */
struct timespec n_localmodtime; /* Last local modify */
};
#define n_atim n_un1.nf_atim