Skip VDEV_IO_DONE stage only for ZIO_TYPE_FREE.
Device removal code uses zio_vdev_child_io() with ZIO_TYPE_NULL parent, that never happened before. It confused FreeBSD-specific TRIM code, which does not use VDEV_IO_DONE for logical ZIO_TYPE_FREE ZIOs. As result of that stage being skipped device removal ZIOs leaked references and memory that supposed to be freed by VDEV_IO_DONE, making it stuck. It is a quick patch rather then a nice fix, but hopefully we'll be able to drop it all together when alternative TRIM implementation finally get landed. PR: 228750, 229007 Discussed with: allanjude, avg, smh Approved by: re (delphij) MFC after: 5 days Sponsored by: iXsystems, Inc.
This commit is contained in:
parent
29bf3a7ba8
commit
2cb74ed856
Notes:
svn2git
2020-12-20 02:59:44 +00:00
svn path=/head/; revision=339372
@ -1180,7 +1180,8 @@ zio_vdev_child_io(zio_t *pio, blkptr_t *bp, vdev_t *vd, uint64_t offset,
|
||||
}
|
||||
|
||||
/* Not all IO types require vdev io done stage e.g. free */
|
||||
if (!(pio->io_pipeline & ZIO_STAGE_VDEV_IO_DONE))
|
||||
if (type == ZIO_TYPE_FREE &&
|
||||
!(pio->io_pipeline & ZIO_STAGE_VDEV_IO_DONE))
|
||||
pipeline &= ~ZIO_STAGE_VDEV_IO_DONE;
|
||||
|
||||
if (vd->vdev_ops->vdev_op_leaf) {
|
||||
|
Loading…
Reference in New Issue
Block a user