d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

krping: Fix for memory leak in error case.

Browse Source 
Submitted by:   hselasky@
Approved by:    hselasky (mentor)
MFC after:      1 week
Sponsored by:   Mellanox Technologies
This commit is contained in:
Slava Shwartsman 2018-12-05 13:27:48 +00:00
parent 186058782a
commit 3006180863
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=341539
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sys/contrib/rdma/krping/krping_dev.c
View File

@ -187,7 +187,7 @@ krping_write(struct cdev *dev, struct uio *uio, int ioflag)
err = uiomove(cp, amt, uio);
if (err) {
uprintf("Write failed: bad address!\n");
return err;
goto done;
}
cp += amt;
remain -= amt;
@ -195,7 +195,8 @@ krping_write(struct cdev *dev, struct uio *uio, int ioflag)
if (uio->uio_resid != 0) {
uprintf("Message too big. max size is %d!\n", BUFFERSIZE);
return EMSGSIZE;
err = EMSGSIZE;
goto done;
}
/* null terminate and remove the \n */
@ -204,6 +205,7 @@ krping_write(struct cdev *dev, struct uio *uio, int ioflag)
krpingmsg->len = (unsigned long)(cp - krpingmsg->msg);
uprintf("krping: write string = |%s|\n", krpingmsg->msg);
err = krping_doit(krpingmsg->msg);
done:
free(krpingmsg, M_DEVBUF);
return(err);
}