From 308224833a4dd0c90174486e2f94671d43b117bf Mon Sep 17 00:00:00 2001 From: Edward Tomasz Napierala Date: Thu, 9 Aug 2018 11:46:12 +0000 Subject: [PATCH] Make ldconfig(8) atomic, by removing an unneccessary call to unlink(2) before rename(2). Reviewed by: kib MFC after: 2 weeks Sponsored by: DARPA, AFRL Differential Revision: https://reviews.freebsd.org/D16641 --- sbin/ldconfig/ldconfig.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/sbin/ldconfig/ldconfig.c b/sbin/ldconfig/ldconfig.c index a9494cc9f6ad..d8318b67815d 100644 --- a/sbin/ldconfig/ldconfig.c +++ b/sbin/ldconfig/ldconfig.c @@ -518,13 +518,6 @@ buildhints(void) warn("%s", hints_file); return -1; } - - /* Install it */ - if (unlink(hints_file) != 0 && errno != ENOENT) { - warn("%s", hints_file); - return -1; - } - if (rename(tmpfilename, hints_file) != 0) { warn("%s", hints_file); return -1;