d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

In usr.bin/make/var.c, function ParseModifier(), initialize the 'error'

Browse Source 
variable to NULL, to avoid using it uninitialized in certain cases.

This fixes the following clang 3.2 warning:

  usr.bin/make/var.c:1770:10: error: variable 'error' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
                                          if (vp->execute) {
                                              ^~~~~~~~~~~
  usr.bin/make/var.c:1777:10: note: uninitialized use occurs here
                                          if (error)
                                              ^~~~~
  usr.bin/make/var.c:1770:6: note: remove the 'if' if its condition is always true
                                          if (vp->execute) {
                                          ^~~~~~~~~~~~~~~~~
  usr.bin/make/var.c:1768:23: note: initialize the variable 'error' to silence this warning
                                          const char      *error;
                                                                ^
                                                                 = NULL

MFC after:      1 week
This commit is contained in:
Dimitry Andric 2012-08-05 15:55:36 +00:00
parent e87f107141
commit 30a845609c
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=239071
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
usr.bin/make/var.c
View File

@ -1765,7 +1765,7 @@ ParseModifier(VarParser *vp, char startc, Var *v, Boolean *freeResult)
if ((vp->ptr[0] == 's') &&
(vp->ptr[1] == 'h') &&
(vp->ptr[2] == endc || vp->ptr[2] == ':')) {
const char *error;
const char *error = NULL;
if (vp->execute) {
newStr = Buf_Peel(