From 3213dc8412824764919f6bcffc91b066cc8cf1e1 Mon Sep 17 00:00:00 2001 From: Ceri Davies Date: Mon, 11 Jun 2007 18:36:39 +0000 Subject: [PATCH] Create group ftp by default. This is gid 14 as this is the historical id used by sysinstall when enabling anonymous FTP. Change the default group used by sysinstall for setting up anonymous FTP from operator to ftp; there is no reason to use operator and there are potential security issues when doing so. PR: 93284 Approved by: ru (mentor) Reviewed by: simon --- etc/group | 1 + usr.sbin/sysinstall/anonFTP.c | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/etc/group b/etc/group index 007acac5a219..044c9f10e143 100644 --- a/etc/group +++ b/etc/group @@ -11,6 +11,7 @@ bin:*:7: news:*:8: man:*:9: games:*:13: +ftp:*:14: staff:*:20: sshd:*:22: smmsp:*:25: diff --git a/usr.sbin/sysinstall/anonFTP.c b/usr.sbin/sysinstall/anonFTP.c index 74270768b4c1..2eaf636a6a85 100644 --- a/usr.sbin/sysinstall/anonFTP.c +++ b/usr.sbin/sysinstall/anonFTP.c @@ -49,8 +49,8 @@ /* These change if we want to use different defaults */ #define FTP_UID 14 -#define FTP_GID 5 -#define FTP_GROUP "operator" +#define FTP_GID 14 +#define FTP_GROUP "ftp" #define FTP_UPLOAD "incoming" #define FTP_COMMENT "Anonymous FTP Admin" #define FTP_HOMEDIR "/var/ftp" @@ -148,7 +148,7 @@ createFtpUser(void) else if (!getgrgid(gid)) { /* group does not exist, create it by number */ - tptr = msgGetInput("14", "What group name to use for gid %d ?", gid); + tptr = msgGetInput("ftp", "What group name to use for gid %d ?", gid); if (tptr && *tptr) { SAFE_STRCPY(tconf.group, tptr); if ((tgrp = getgrnam(tconf.group))) {