kern: soclose: don't sleep on SO_LINGER w/ timeout=0
This is a valid scenario that's handled in the various protocol layers where it makes sense (e.g., tcp_disconnect and sctp_disconnect). Given that it indicates we should immediately drop the connection, it makes little sense to sleep on it. This could lead to panics with INVARIANTS. On non-INVARIANTS kernels, this could result in the thread hanging until a signal interrupts it if the protocol does not mark the socket as disconnected for whatever reason. Reported by: syzbot+e625d92c1dd74e402c81@syzkaller.appspotmail.com Reviewed by: glebius, markj MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D27407
This commit is contained in:
parent
df9053920f
commit
34af05ead3
Notes:
svn2git
2020-12-20 02:59:44 +00:00
svn path=/head/; revision=368326
@ -1192,7 +1192,8 @@ soclose(struct socket *so)
|
||||
goto drop;
|
||||
}
|
||||
}
|
||||
if (so->so_options & SO_LINGER) {
|
||||
|
||||
if ((so->so_options & SO_LINGER) != 0 && so->so_linger != 0) {
|
||||
if ((so->so_state & SS_ISDISCONNECTING) &&
|
||||
(so->so_state & SS_NBIO))
|
||||
goto drop;
|
||||
|
Loading…
Reference in New Issue
Block a user