d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lockmgr(...,LK_DRAIN,...) requires a balancing LK_RELEASE: recent

Browse Source 
INVARIANTS dependent checks in userret() pinpointed a missing
invocation here.

Remove an unused variable while here.

Reviewed By: bp@
Reported By: yongari@
MFC After: 3 days
This commit is contained in:
Peter Edwards 2005-05-13 11:27:48 +00:00
parent 265da99ce9
commit 34ddec12b1
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=146179
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sys/netsmb/smb_conn.c
View File

@ -95,6 +95,7 @@ smb_sm_done(void)
SMBERROR("%d connections still active\n", smb_vclist.co_usecount - 1);
return EBUSY;
}
lockmgr(&smb_vclist.co_lock, LK_DRAIN, 0, curthread);
smb_co_done(&smb_vclist);
return 0;
}
@ -239,6 +240,7 @@ static void
smb_co_done(struct smb_connobj *cp)
{
smb_sl_destroy(&cp->co_interlock);
lockmgr(&cp->co_lock, LK_RELEASE, 0, curthread);
lockdestroy(&cp->co_lock);
}
@ -313,16 +315,13 @@ void
smb_co_put(struct smb_connobj *cp, struct smb_cred *scred)
{
struct thread *td = scred->scr_td;
int flags;
flags = LK_RELEASE;
SMB_CO_LOCK(cp);
if (cp->co_usecount > 1) {
cp->co_usecount--;
} else if (cp->co_usecount == 1) {
cp->co_usecount--;
cp->co_flags |= SMBO_GONE;
flags = LK_DRAIN;
} else {
SMBERROR("negative usecount");
}