d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Only clear the 'free' bit if we were successful in getting a queue item off the free list.

Browse Source 
Found by: Harti Brandt (address unknown)
This commit is contained in:
Julian Elischer 2001-01-25 19:48:57 +00:00
parent b00df9c9ba
commit 34f9ca0908
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=71650
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sys/netgraph/ng_base.c
View File

@ -3027,7 +3027,7 @@ ng_getqblk(void)
* ngqfree is the final arbiter. We have our little reserve
* because we use M_NOWAIT for malloc. This just helps us
* avoid dropping packets while not increasing the time
* we take to service the interrupt (on average) (we hope).
* we take to service the interrupt (on average) (I hope).
*/
for (;;) {
if ((ngqfreesize < ngqfreelow) || (ngqfree == NULL)) {
@ -3062,15 +3062,19 @@ ng_getqblk(void)
*/
if (atomic_cmpset_ptr(&ngqfree, item, item->el_next)) {
atomic_subtract_int(&ngqfreesize, 1);
item->el_flags &= ~NGQF_FREE;
break;
}
/*
* something got there before we did.. try again
* (go around the loop again)
*/
item = NULL;
} else {
/* We really ran out */
break;
}
}
item->el_flags &= ~NGQF_FREE;
return (item);
}