d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Temporary fix for guest idle detection.

Browse Source 
Handle ExtINT injection for SVM. The HPET emulation
will inject a legacy interrupt at startup, and if this
isn't handled, will result in the HLT-exit code assuming
there are outstanding ExtINTs and return without sleeping.

svm_inj_interrupts() needs more changes to bring it up
to date with the VT-x version: these are forthcoming.

Reviewed by:	neel
This commit is contained in:
Peter Grehan 2014-06-09 21:02:48 +00:00
parent 1cc0e0eedb
commit 3787148758
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/projects/bhyve_svm/; revision=267305
1 changed files with 25 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
sys/amd64/vmm/amd/svm.c
View File

@ -56,6 +56,7 @@ __FBSDID("$FreeBSD$");
#include "vmm_stat.h" #include "vmm_stat.h"
#include "vmm_ktr.h" #include "vmm_ktr.h"
#include "vmm_ioport.h" #include "vmm_ioport.h"
#include "vatpic.h"
#include "vlapic.h" #include "vlapic.h"
#include "vlapic_priv.h" #include "vlapic_priv.h"
@ -952,6 +953,7 @@ svm_inj_interrupts(struct svm_softc *svm_sc, int vcpu, struct vlapic *vlapic)
struct vmcb_ctrl *ctrl; struct vmcb_ctrl *ctrl;
struct vmcb_state *state; struct vmcb_state *state;
struct vm_exception exc; struct vm_exception exc;
int extint_pending;
int vector; int vector;
KASSERT(vcpu < svm_sc->vcpu_cnt, ("Guest doesn't have VCPU%d", vcpu)); KASSERT(vcpu < svm_sc->vcpu_cnt, ("Guest doesn't have VCPU%d", vcpu));
@ -988,10 +990,17 @@ svm_inj_interrupts(struct svm_softc *svm_sc, int vcpu, struct vlapic *vlapic)
return; return;
} }
/* Ask the local apic for a vector to inject */ extint_pending = vm_extint_pending(svm_sc->vm, vcpu);
if (!vlapic_pending_intr(vlapic, &vector))
return; if (!extint_pending) {
/* Ask the local apic for a vector to inject */
if (!vlapic_pending_intr(vlapic, &vector))
return;
} else {
/* Ask the legacy pic for a vector to inject */
vatpic_pending_intr(svm_sc->vm, &vector);
}
if (vector < 32 || vector > 255) { if (vector < 32 || vector > 255) {
VCPU_CTR1(svm_sc->vm, vcpu, "SVM_ERR:Event injection" VCPU_CTR1(svm_sc->vm, vcpu, "SVM_ERR:Event injection"
"invalid vector=%d.\n", vector); "invalid vector=%d.\n", vector);
@ -1010,8 +1019,18 @@ svm_inj_interrupts(struct svm_softc *svm_sc, int vcpu, struct vlapic *vlapic)
return; return;
} }
/* Acknowledge that event is accepted.*/ if (!extint_pending) {
vlapic_intr_accepted(vlapic, vector); /* Update the Local APIC ISR */
vlapic_intr_accepted(vlapic, vector);
} else {
vm_extint_clear(svm_sc->vm, vcpu);
vatpic_intr_accepted(svm_sc->vm, vector);
/*
* XXX need to recheck exting_pending ala VT-x
*/
}
VCPU_CTR1(svm_sc->vm, vcpu, "SVM:event injected,vector=%d.\n", vector); VCPU_CTR1(svm_sc->vm, vcpu, "SVM:event injected,vector=%d.\n", vector);
} }