We cannot open file for reading and executing (O_RDONLY | O_EXEC).
Well, in theory we can pass those two flags, because O_RDONLY is 0, but we won't be able to read from a descriptor opened with O_EXEC. Update the comment. Sponsored by: FreeBSD Foundation MFC after: 2 weeks
This commit is contained in:
parent
5c3e5c7f03
commit
3a038c4d68
Notes:
svn2git
2020-12-20 02:59:44 +00:00
svn path=/head/; revision=240931
@ -441,10 +441,10 @@ do_execve(td, args, mac_p)
|
||||
} else {
|
||||
AUDIT_ARG_FD(args->fd);
|
||||
/*
|
||||
* Some might argue that CAP_READ and/or CAP_MMAP should also
|
||||
* be required here; such arguments will be entertained.
|
||||
* Some might argue that CAP_MMAP should also be required here;
|
||||
* such arguments will be entertained.
|
||||
*
|
||||
* Descriptors opened only with O_EXEC or O_RDONLY are allowed.
|
||||
* Descriptors opened only with O_EXEC are allowed.
|
||||
*/
|
||||
error = fgetvp_exec(td, args->fd, CAP_FEXECVE, &binvp);
|
||||
if (error)
|
||||
|
Loading…
Reference in New Issue
Block a user