d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

dhclient violates RFC2131 when sending early DHCPREQUEST message to re-obtain old IP

Browse Source 
When dhclient first starts, if an old IP address exists in the
dhclient.leases file, dhclient(8) sends early DHCPREQUEST message(s)
in an attempt to re-obtain the old IP address again. These messages
contain the old IP as a requested-IP-address option in the message
body (correct) but also use the old IP address as the packet's source
IP (incorrect).

RFC2131 sec 4.1 states:

  DHCP messages broadcast by a client prior to that client obtaining
  its IP address must have the source address field in the IP header
  set to 0.

The use of the old IP as the packet's source address is incorrect if
(a) the computer is now on a different network or (b) it is on the
same network, but the old IP has been reallocated to another host.

Fix dhclient to use 0.0.0.0 as the source IP in this circumstance
without removing any existing functionality. Any previously-used old
IP is still requested in the body of an early DHCPREQUEST message.

PR:		199378
Submitted by:	J.R. Oldroyd <fbsd@opal.com>
Reported by:	J.R. Oldroyd <fbsd@opal.com>
Reviewed by:	cem, asomers, vangyzen
MFC after:	1 week
Sponsored by:	Dell EMC
Differential Revision:	https://reviews.freebsd.org/D14527
This commit is contained in:
David Bright 2018-02-27 21:59:23 +00:00
parent d5b2439e5d
commit 3acf1760b7
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=330085
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sbin/dhclient/dhclient.c
View File

@ -1513,7 +1513,8 @@ send_request(void *ipp)
memcpy(&to.s_addr, ip->client->destination.iabuf, memcpy(&to.s_addr, ip->client->destination.iabuf,
sizeof(to.s_addr)); sizeof(to.s_addr));
if (ip->client->state != S_REQUESTING) if (ip->client->state != S_REQUESTING &&
ip->client->state != S_REBOOTING)
memcpy(&from, ip->client->active->address.iabuf, memcpy(&from, ip->client->active->address.iabuf,
sizeof(from)); sizeof(from));
else else