d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

igc: Change default duplex setting

Browse Source 
During media selection through ifconfig one might not specify
the duplex setting through the mediaopt flag.
In that case the igc driver would default to full-duplex.
The problem with this approach is that e1000(em/igb) driver
defaults to half-duplex.
Because of that if one connects both NICs and sets media to
e.g. 100baseTX on both of them no link will be found.
Fix that by matching igc behaviour with what e1000 does.

Reviewed by: grehan
Approved by: mw(mentor)
Obtained from: Semihalf
Sponsored by: Stormshield
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D35673
This commit is contained in:
Kornel Dulęba 2022-06-30 13:57:58 +02:00
parent ab453714fc
commit 3b8d04f845
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
sys/dev/igc/if_igc.c
View File

@ -1070,16 +1070,16 @@ igc_if_media_change(if_ctx_t ctx)
adapter->hw.phy.autoneg_advertised = ADVERTISE_1000_FULL;
break;
case IFM_100_TX:
if ((ifm->ifm_media & IFM_GMASK) == IFM_HDX)
adapter->hw.phy.autoneg_advertised = ADVERTISE_100_HALF;
else
if ((ifm->ifm_media & IFM_GMASK) == IFM_FDX)
adapter->hw.phy.autoneg_advertised = ADVERTISE_100_FULL;
else
adapter->hw.phy.autoneg_advertised = ADVERTISE_100_HALF;
break;
case IFM_10_T:
if ((ifm->ifm_media & IFM_GMASK) == IFM_HDX)
adapter->hw.phy.autoneg_advertised = ADVERTISE_10_HALF;
else
if ((ifm->ifm_media & IFM_GMASK) == IFM_FDX)
adapter->hw.phy.autoneg_advertised = ADVERTISE_10_FULL;
else
adapter->hw.phy.autoneg_advertised = ADVERTISE_10_HALF;
break;
default:
device_printf(adapter->dev, "Unsupported media type\n");