d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

camcontrol powermode: fix use-after-free

Browse Source 
Free the ccb after processing the response therein.

Reported by:	Coverity
Fixes:		3bed0179ee
MFC after:	1 week
Sponsored by:	Dell EMC Isilon
This commit is contained in:
Eric van Gyzen 2023-03-29 14:14:40 -05:00
parent 8f391d9098
commit 3bbd1a1a00
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
sbin/camcontrol/camcontrol.c
View File

@ -9312,12 +9312,11 @@ atapm(struct cam_device *device, int argc, char **argv,
/*timeout*/timeout ? timeout : 30 * 1000,
/*force48bit*/0);
if (retval == 0 && cmd == ATA_CHECK_POWER_MODE)
retval = atapm_proc_resp(device, ccb);
cam_freeccb(ccb);
if (retval || cmd != ATA_CHECK_POWER_MODE)
return (retval);
return (atapm_proc_resp(device, ccb));
return (retval);
}
static int