iflib: mark irq allocation name parameter as constant
The *name parameter passed to iflib_irq_alloc_generic and iflib_softirq_alloc_generic is never modified. Many places in code pass string literals and thus should not be modified. Mark the *name parameter as a const char * instead, so that we enforce that the name is not modified before passing to bus_describe_intr() Submitted by: Jacob Keller <jacob.e.keller@intel.com> Reviewed by: kmacy Sponsored by: Intel Corporation Differential Revision: https://reviews.freebsd.org/D15343
This commit is contained in:
parent
21a8e0b1d5
commit
3e0e6330b5
Notes:
svn2git
2020-12-20 02:59:44 +00:00
svn path=/head/; revision=334358
@ -561,7 +561,7 @@ struct taskqgroup_cpu {
|
||||
struct taskqgroup {
|
||||
struct taskqgroup_cpu tqg_queue[MAXCPU];
|
||||
struct mtx tqg_lock;
|
||||
char * tqg_name;
|
||||
const char * tqg_name;
|
||||
int tqg_adjusting;
|
||||
int tqg_stride;
|
||||
int tqg_cnt;
|
||||
@ -720,7 +720,7 @@ taskqgroup_attach_deferred(struct taskqgroup *qgroup, struct grouptask *gtask)
|
||||
|
||||
int
|
||||
taskqgroup_attach_cpu(struct taskqgroup *qgroup, struct grouptask *gtask,
|
||||
void *uniq, int cpu, int irq, char *name)
|
||||
void *uniq, int cpu, int irq, const char *name)
|
||||
{
|
||||
cpuset_t mask;
|
||||
int i, qid, error;
|
||||
@ -961,7 +961,7 @@ taskqgroup_adjust(struct taskqgroup *qgroup, int cnt, int stride)
|
||||
}
|
||||
|
||||
struct taskqgroup *
|
||||
taskqgroup_create(char *name)
|
||||
taskqgroup_create(const char *name)
|
||||
{
|
||||
struct taskqgroup *qgroup;
|
||||
|
||||
|
@ -733,7 +733,7 @@ static int iflib_tx_credits_update(if_ctx_t ctx, iflib_txq_t txq);
|
||||
static int iflib_rxd_avail(if_ctx_t ctx, iflib_rxq_t rxq, qidx_t cidx, qidx_t budget);
|
||||
static int iflib_qset_structures_setup(if_ctx_t ctx);
|
||||
static int iflib_msix_init(if_ctx_t ctx);
|
||||
static int iflib_legacy_setup(if_ctx_t ctx, driver_filter_t filter, void *filterarg, int *rid, char *str);
|
||||
static int iflib_legacy_setup(if_ctx_t ctx, driver_filter_t filter, void *filterarg, int *rid, const char *str);
|
||||
static void iflib_txq_check_drain(iflib_txq_t txq, int budget);
|
||||
static uint32_t iflib_txq_can_drain(struct ifmp_ring *);
|
||||
static int iflib_register(if_ctx_t);
|
||||
@ -1523,8 +1523,8 @@ iflib_fast_intr_ctx(void *arg)
|
||||
|
||||
static int
|
||||
_iflib_irq_alloc(if_ctx_t ctx, if_irq_t irq, int rid,
|
||||
driver_filter_t filter, driver_intr_t handler, void *arg,
|
||||
char *name)
|
||||
driver_filter_t filter, driver_intr_t handler, void *arg,
|
||||
const char *name)
|
||||
{
|
||||
int rc, flags;
|
||||
struct resource *res;
|
||||
@ -5395,7 +5395,7 @@ iflib_qset_structures_setup(if_ctx_t ctx)
|
||||
|
||||
int
|
||||
iflib_irq_alloc(if_ctx_t ctx, if_irq_t irq, int rid,
|
||||
driver_filter_t filter, void *filter_arg, driver_intr_t handler, void *arg, char *name)
|
||||
driver_filter_t filter, void *filter_arg, driver_intr_t handler, void *arg, const char *name)
|
||||
{
|
||||
|
||||
return (_iflib_irq_alloc(ctx, irq, rid, filter, handler, arg, name));
|
||||
@ -5526,7 +5526,7 @@ get_core_offset(if_ctx_t ctx, iflib_intr_type_t type, int qid)
|
||||
/* Just to avoid copy/paste */
|
||||
static inline int
|
||||
iflib_irq_set_affinity(if_ctx_t ctx, int irq, iflib_intr_type_t type, int qid,
|
||||
struct grouptask *gtask, struct taskqgroup *tqg, void *uniq, char *name)
|
||||
struct grouptask *gtask, struct taskqgroup *tqg, void *uniq, const char *name)
|
||||
{
|
||||
int cpuid;
|
||||
int err, tid;
|
||||
@ -5549,8 +5549,8 @@ iflib_irq_set_affinity(if_ctx_t ctx, int irq, iflib_intr_type_t type, int qid,
|
||||
|
||||
int
|
||||
iflib_irq_alloc_generic(if_ctx_t ctx, if_irq_t irq, int rid,
|
||||
iflib_intr_type_t type, driver_filter_t *filter,
|
||||
void *filter_arg, int qid, char *name)
|
||||
iflib_intr_type_t type, driver_filter_t *filter,
|
||||
void *filter_arg, int qid, const char *name)
|
||||
{
|
||||
struct grouptask *gtask;
|
||||
struct taskqgroup *tqg;
|
||||
@ -5631,7 +5631,7 @@ iflib_irq_alloc_generic(if_ctx_t ctx, if_irq_t irq, int rid,
|
||||
}
|
||||
|
||||
void
|
||||
iflib_softirq_alloc_generic(if_ctx_t ctx, if_irq_t irq, iflib_intr_type_t type, void *arg, int qid, char *name)
|
||||
iflib_softirq_alloc_generic(if_ctx_t ctx, if_irq_t irq, iflib_intr_type_t type, void *arg, int qid, const char *name)
|
||||
{
|
||||
struct grouptask *gtask;
|
||||
struct taskqgroup *tqg;
|
||||
@ -5688,7 +5688,7 @@ iflib_irq_free(if_ctx_t ctx, if_irq_t irq)
|
||||
}
|
||||
|
||||
static int
|
||||
iflib_legacy_setup(if_ctx_t ctx, driver_filter_t filter, void *filter_arg, int *rid, char *name)
|
||||
iflib_legacy_setup(if_ctx_t ctx, driver_filter_t filter, void *filter_arg, int *rid, const char *name)
|
||||
{
|
||||
iflib_txq_t txq = ctx->ifc_txqs;
|
||||
iflib_rxq_t rxq = ctx->ifc_rxqs;
|
||||
|
@ -404,11 +404,11 @@ int iflib_device_deregister(if_ctx_t);
|
||||
|
||||
|
||||
|
||||
int iflib_irq_alloc(if_ctx_t, if_irq_t, int, driver_filter_t, void *filter_arg, driver_intr_t, void *arg, char *name);
|
||||
int iflib_irq_alloc(if_ctx_t, if_irq_t, int, driver_filter_t, void *filter_arg, driver_intr_t, void *arg, const char *name);
|
||||
int iflib_irq_alloc_generic(if_ctx_t ctx, if_irq_t irq, int rid,
|
||||
iflib_intr_type_t type, driver_filter_t *filter,
|
||||
void *filter_arg, int qid, char *name);
|
||||
void iflib_softirq_alloc_generic(if_ctx_t ctx, if_irq_t irq, iflib_intr_type_t type, void *arg, int qid, char *name);
|
||||
iflib_intr_type_t type, driver_filter_t *filter,
|
||||
void *filter_arg, int qid, const char *name);
|
||||
void iflib_softirq_alloc_generic(if_ctx_t ctx, if_irq_t irq, iflib_intr_type_t type, void *arg, int qid, const char *name);
|
||||
|
||||
void iflib_irq_free(if_ctx_t ctx, if_irq_t irq);
|
||||
|
||||
|
@ -56,9 +56,9 @@ int grouptaskqueue_enqueue(struct gtaskqueue *queue, struct gtask *task);
|
||||
void taskqgroup_attach(struct taskqgroup *qgroup, struct grouptask *grptask,
|
||||
void *uniq, int irq, const char *name);
|
||||
int taskqgroup_attach_cpu(struct taskqgroup *qgroup, struct grouptask *grptask,
|
||||
void *uniq, int cpu, int irq, char *name);
|
||||
void *uniq, int cpu, int irq, const char *name);
|
||||
void taskqgroup_detach(struct taskqgroup *qgroup, struct grouptask *gtask);
|
||||
struct taskqgroup *taskqgroup_create(char *name);
|
||||
struct taskqgroup *taskqgroup_create(const char *name);
|
||||
void taskqgroup_destroy(struct taskqgroup *qgroup);
|
||||
int taskqgroup_adjust(struct taskqgroup *qgroup, int cnt, int stride);
|
||||
void taskqgroup_config_gtask_init(void *ctx, struct grouptask *gtask, gtask_fn_t *fn,
|
||||
|
Loading…
Reference in New Issue
Block a user