d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix Coverity issue in the NVDIMM driver

Browse Source 
Summary:
Coverity reports a potential memory leak in the nvdimm
driver. Examination shows it's real; fix it.

Sponsored by: Dell Technologies
MFC after: 1w

Test Plan: Changes in use at $WORK

Reviewers: robert.herndon_dell.com, vangyzen, bret_ketchum_dell.com

Subscribers: imp, badger

Differential Revision: https://reviews.freebsd.org/D38676
This commit is contained in:
Robert Herndon 2022-10-13 12:02:28 -05:00 committed by David Bright
parent 453aa7fac9
commit 3ff497061b
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
sys/dev/nvdimm/nvdimm_acpi.c
View File

@ -67,14 +67,18 @@ find_dimm(ACPI_HANDLE handle, UINT32 nesting_level, void *context,
ACPI_DEVICE_INFO *device_info;
ACPI_STATUS status;
device_info = NULL;
status = AcpiGetObjectInfo(handle, &device_info);
if (ACPI_FAILURE(status))
return_ACPI_STATUS(AE_ERROR);
if (device_info->Address == (uintptr_t)context) {
*(ACPI_HANDLE *)return_value = handle;
return_ACPI_STATUS(AE_CTRL_TERMINATE);
}
return_ACPI_STATUS(AE_OK);
status = AE_CTRL_TERMINATE;
} else
status = AE_OK;
AcpiOsFree(device_info);
return_ACPI_STATUS(status);
}
static ACPI_HANDLE